From: greg@kroah.com (Greg KH)
To: Justin Thiessen <jthiessen@penguincomputing.com>
Cc: phil@netroedge.com, khali@linux-fr.org,
sensors@Stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver,
Date: Thu, 19 May 2005 06:25:24 +0000 [thread overview]
Message-ID: <20041124223500.GA3787@kroah.com> (raw)
In-Reply-To: <20041124231017.GA10171@penguincomputing.com>
On Wed, Nov 24, 2004 at 03:10:17PM -0800, Justin Thiessen wrote:
> On Wed, Nov 24, 2004 at 01:36:00PM -0800, Greg KH wrote:
> > Hm, this looks like a bug:
>
> <snip egregious stupidity>
>
> > Care to fix this up and resend the whole patch?
>
> Affirmative.
>
> > Oh, and it should be "Signed-off-by:" not "Signed off by:" like you had
> > used :)
>
> See below:
Applied, thanks.
Oh, I did make one change:
> +/* Adjust fan_min to account for new fan divisor */
> +void fixup_fan_min(struct device *dev, int fan, int old_div)
This should be static.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Justin Thiessen <jthiessen@penguincomputing.com>
Cc: phil@netroedge.com, khali@linux-fr.org,
sensors@Stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: Re: adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) [fixed]
Date: Wed, 24 Nov 2004 14:35:00 -0800 [thread overview]
Message-ID: <20041124223500.GA3787@kroah.com> (raw)
In-Reply-To: <20041124231017.GA10171@penguincomputing.com>
On Wed, Nov 24, 2004 at 03:10:17PM -0800, Justin Thiessen wrote:
> On Wed, Nov 24, 2004 at 01:36:00PM -0800, Greg KH wrote:
> > Hm, this looks like a bug:
>
> <snip egregious stupidity>
>
> > Care to fix this up and resend the whole patch?
>
> Affirmative.
>
> > Oh, and it should be "Signed-off-by:" not "Signed off by:" like you had
> > used :)
>
> See below:
Applied, thanks.
Oh, I did make one change:
> +/* Adjust fan_min to account for new fan divisor */
> +void fixup_fan_min(struct device *dev, int fan, int old_div)
This should be static.
thanks,
greg k-h
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:25 adm1026 driver port for kernel 2.6.X Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Mark M. Hoffman
2005-05-19 6:25 ` Justin Thiessen
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Justin Thiessen
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Justin Thiessen
2004-11-02 16:46 ` adm1026 driver port for kernel 2.6.X - [REVISED DRIVER] Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-02 19:31 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-11-02 22:17 ` Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-03 8:01 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-11-03 16:43 ` adm1026 driver port for kernel 2.6.X - [RE-REVISED DRIVER] Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-16 18:56 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-11-18 18:56 ` adm1026 driver port for kernel 2.6.10-rc2 " Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-20 9:57 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-11-22 19:35 ` Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-20 10:13 ` Arjan van de Ven
2005-05-19 6:25 ` Arjan van de Ven
2004-11-20 10:32 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-11-22 19:43 ` Justin Thiessen
2005-05-19 6:25 ` Justin Thiessen
2004-11-22 21:00 ` Arjan van de Ven
2005-05-19 6:25 ` Arjan van de Ven
2004-11-22 21:30 ` linux-os
2005-05-19 6:25 ` linux-os
2004-11-23 17:58 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-11-23 16:52 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) Justin Thiessen
2005-05-19 6:25 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, Justin Thiessen
2004-11-23 17:50 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) Jean Delvare
2005-05-19 6:25 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes Jean Delvare
2004-11-24 21:36 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) Greg KH
2005-05-19 6:25 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, Greg KH
2004-11-24 23:10 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile) [fixed] Justin Thiessen
2005-05-19 6:25 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes Justin Thiessen
2004-11-24 22:35 ` Greg KH [this message]
2005-05-19 6:25 ` adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124223500.GA3787@kroah.com \
--to=greg@kroah.com \
--cc=jthiessen@penguincomputing.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@netroedge.com \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.