From: Dmitry Torokhov <dtor_core@ameritech.net>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Gerd Knorr <kraxel@bytesex.org>
Subject: [PATCH] v4l: fix permissions on module parameters exported via sysfs
Date: Thu, 25 Nov 2004 01:38:27 -0500 [thread overview]
Message-ID: <200411250138.27831.dtor_core@ameritech.net> (raw)
Another case of 0 missing from octal encoding.
--
Dmitry
===================================================================
ChangeSet@1.1969, 2004-11-25 00:40:44-05:00, dtor_core@ameritech.net
v4l: Fix permissions on module parameters exported via sysfs.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
tuner.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
===================================================================
diff -Nru a/drivers/media/video/tuner.c b/drivers/media/video/tuner.c
--- a/drivers/media/video/tuner.c 2004-11-25 01:27:47 -05:00
+++ b/drivers/media/video/tuner.c 2004-11-25 01:27:47 -05:00
@@ -30,24 +30,24 @@
/* insmod options used at init time => read/only */
static unsigned int type = UNSET;
static unsigned int addr = 0;
-module_param(type, int, 444);
-module_param(addr, int, 444);
+module_param(type, int, 0444);
+module_param(addr, int, 0444);
/* insmod options used at runtime => read/write */
static unsigned int debug = 0;
static unsigned int tv_antenna = 1;
static unsigned int radio_antenna = 0;
static unsigned int optimize_vco = 1;
-module_param(debug, int, 644);
-module_param(tv_antenna, int, 644);
-module_param(radio_antenna, int, 644);
-module_param(optimize_vco, int, 644);
+module_param(debug, int, 0644);
+module_param(tv_antenna, int, 0644);
+module_param(radio_antenna, int, 0644);
+module_param(optimize_vco, int, 0644);
static unsigned int tv_range[2] = { 44, 958 };
static unsigned int radio_range[2] = { 65, 108 };
-module_param_array(tv_range, int, NULL, 644);
-module_param_array(radio_range, int, NULL, 644);
+module_param_array(tv_range, int, NULL, 0644);
+module_param_array(radio_range, int, NULL, 0644);
MODULE_DESCRIPTION("device driver for various TV and TV+FM radio tuners");
MODULE_AUTHOR("Ralph Metzler, Gerd Knorr, Gunther Mayer");
reply other threads:[~2004-11-25 6:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411250138.27831.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.