All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] v4l: fix permissions on module parameters exported via sysfs
@ 2004-11-25  6:38 Dmitry Torokhov
  0 siblings, 0 replies; only message in thread
From: Dmitry Torokhov @ 2004-11-25  6:38 UTC (permalink / raw)
  To: LKML; +Cc: Andrew Morton, Gerd Knorr

Another case of 0 missing from octal encoding.

-- 
Dmitry


===================================================================


ChangeSet@1.1969, 2004-11-25 00:40:44-05:00, dtor_core@ameritech.net
  v4l: Fix permissions on module parameters exported via sysfs.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>


 tuner.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)


===================================================================



diff -Nru a/drivers/media/video/tuner.c b/drivers/media/video/tuner.c
--- a/drivers/media/video/tuner.c	2004-11-25 01:27:47 -05:00
+++ b/drivers/media/video/tuner.c	2004-11-25 01:27:47 -05:00
@@ -30,24 +30,24 @@
 /* insmod options used at init time => read/only */
 static unsigned int type  =  UNSET;
 static unsigned int addr  =  0;
-module_param(type, int, 444);
-module_param(addr, int, 444);
+module_param(type, int, 0444);
+module_param(addr, int, 0444);
 
 /* insmod options used at runtime => read/write */
 static unsigned int debug         = 0;
 static unsigned int tv_antenna    = 1;
 static unsigned int radio_antenna = 0;
 static unsigned int optimize_vco  = 1;
-module_param(debug,             int, 644);
-module_param(tv_antenna,        int, 644);
-module_param(radio_antenna,     int, 644);
-module_param(optimize_vco,      int, 644);
+module_param(debug,             int, 0644);
+module_param(tv_antenna,        int, 0644);
+module_param(radio_antenna,     int, 0644);
+module_param(optimize_vco,      int, 0644);
 
 static unsigned int tv_range[2]    = { 44, 958 };
 static unsigned int radio_range[2] = { 65, 108 };
 
-module_param_array(tv_range,    int, NULL, 644);
-module_param_array(radio_range, int, NULL, 644);
+module_param_array(tv_range,    int, NULL, 0644);
+module_param_array(radio_range, int, NULL, 0644);
 
 MODULE_DESCRIPTION("device driver for various TV and TV+FM radio tuners");
 MODULE_AUTHOR("Ralph Metzler, Gerd Knorr, Gunther Mayer");

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-11-25  6:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-25  6:38 [PATCH] v4l: fix permissions on module parameters exported via sysfs Dmitry Torokhov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.