From: Adrian Bunk <bunk@stusta.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ghozlane Toumi <gtoumi@laposte.net>,
Antonino Daplas <adaplas@pol.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [2.6 patch] sstfb.c: make some code static
Date: Thu, 25 Nov 2004 16:36:07 +0100 [thread overview]
Message-ID: <20041125153607.GC3537@stusta.de> (raw)
In-Reply-To: <1101336587.2571.1.camel@localhost.localdomain>
On Wed, Nov 24, 2004 at 10:49:47PM +0000, Alan Cox wrote:
> On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote:
> > The patch below makes some needlessly global code static.
>
> No it doesn't. It makes some functions static (which is fine) and adds
> some nasty messy pointless #ifdefs. It touches no variable at all.
>
> Please check your description texts and also don't fill the kernel with
> ifdef crap. Probably the __setup stuff should be a module param new
> style too.
Yes, the description text could have been better.
The "ifdef crap" comes from the fact, that after making the functions
static, gcc warns if they are unused.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ghozlane Toumi <gtoumi@laposte.net>,
Antonino Daplas <adaplas@pol.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [2.6 patch] sstfb.c: make some code static
Date: Thu, 25 Nov 2004 16:36:07 +0100 [thread overview]
Message-ID: <20041125153607.GC3537@stusta.de> (raw)
In-Reply-To: <1101336587.2571.1.camel@localhost.localdomain>
On Wed, Nov 24, 2004 at 10:49:47PM +0000, Alan Cox wrote:
> On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote:
> > The patch below makes some needlessly global code static.
>
> No it doesn't. It makes some functions static (which is fine) and adds
> some nasty messy pointless #ifdefs. It touches no variable at all.
>
> Please check your description texts and also don't fill the kernel with
> ifdef crap. Probably the __setup stuff should be a module param new
> style too.
Yes, the description text could have been better.
The "ifdef crap" comes from the fact, that after making the functions
static, gcc warns if they are unused.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-11-25 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:36 [2.6 patch] sstfb.c: make some code static Adrian Bunk
2004-11-24 22:49 ` Alan Cox
2004-11-24 22:49 ` Alan Cox
2004-11-25 15:36 ` Adrian Bunk [this message]
2004-11-25 15:36 ` Adrian Bunk
2004-11-25 16:50 ` Alan Cox
2004-11-25 16:50 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2005-02-11 18:54 Adrian Bunk
2005-02-11 18:54 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041125153607.GC3537@stusta.de \
--to=bunk@stusta.de \
--cc=adaplas@pol.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gtoumi@laposte.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.