All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Manfred Schwarb <manfred99@gmx.ch>
Cc: chas@cmf.nrl.navy.mil,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org,
	linux-atm-general@lists.sourceforge.net
Subject: [2.6 patch] Build Error 2: build of pca200e.bin fails
Date: Sun, 28 Nov 2004 20:21:21 +0100	[thread overview]
Message-ID: <20041128192121.GE4390@stusta.de> (raw)
In-Reply-To: <20041119100327.32511.6195.54797@tp-meteodat6.cyberlink.ch>

On Fri, Nov 19, 2004 at 05:03:29AM -0500, Manfred Schwarb wrote:
> Hi,
> 
> OK, I know I'm stupid...
> I always forget to unset my GZIP options, as I have
> "export GZIP='-9 -N'" in my .bashrc.
> 
> This results in the following:
> 
> objcopy -Iihex pca200e.data -Obinary pca200e.bin.gz
> gzip -df pca200e.bin.gz
> ./fore200e_mkfirm -k -b _fore200e_pca_fw \
>   -i pca200e.bin -o fore200e_pca_fw.c
> ./fore200e_mkfirm: can't open pca200e.bin for reading
> make[2]: *** [fore200e_pca_fw.c] Error 254
> make[2]: Leaving directory `/usr/src/linux-2.4.28/drivers/atm'
> make[1]: *** [_modsubdir_atm] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.4.28/drivers'
> make: *** [_mod_drivers] Error 2
> 
> 
> The following patch would correct this:
> 
> --- linux-2.4.28/drivers/atm/Makefile.orig	2004-11-19 09:33:21.000000000 +0000
> +++ linux-2.4.28/drivers/atm/Makefile	2004-11-19 09:38:07.000000000 +0000
> @@ -92,7 +92,7 @@
>  # deal with the various suffixes of the binary firmware images
>  %.bin %.bin1 %.bin2: %.data
>  	objcopy -Iihex $< -Obinary $@.gz
> -	gzip -df $@.gz
> +	gzip -n -df $@.gz
>  
>  fore_200e.o: $(fore_200e-objs)
>  	$(LD) -r -o $@ $(fore_200e-objs)


I have no problems with this patch, but shouldn't the same be done
in 2.6?


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.10-rc2-mm3-full/drivers/atm/Makefile.old	2004-11-28 20:18:04.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/atm/Makefile	2004-11-28 20:18:15.000000000 +0100
@@ -68,4 +68,4 @@
 # deal with the various suffixes of the binary firmware images
 $(obj)/%.bin $(obj)/%.bin1 $(obj)/%.bin2: $(src)/%.data
 	objcopy -Iihex $< -Obinary $@.gz
-	gzip -df $@.gz
+	gzip -n -df $@.gz


  reply	other threads:[~2004-11-28 19:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19 10:03 [2.4.28] Build Error 2: build of pca200e.bin fails Manfred Schwarb
2004-11-28 19:21 ` Adrian Bunk [this message]
2004-11-30 17:00   ` [2.6 patch] " Marcelo Tosatti
2004-12-01  2:36     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041128192121.GE4390@stusta.de \
    --to=bunk@stusta.de \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred99@gmx.ch \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.