From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Manfred Schwarb <manfred99@gmx.ch>,
chas@cmf.nrl.navy.mil, linux-kernel@vger.kernel.org,
linux-atm-general@lists.sourceforge.net
Subject: Re: [2.6 patch] Build Error 2: build of pca200e.bin fails
Date: Tue, 30 Nov 2004 15:00:31 -0200 [thread overview]
Message-ID: <20041130170031.GD5009@dmt.cyclades> (raw)
In-Reply-To: <20041128192121.GE4390@stusta.de>
On Sun, Nov 28, 2004 at 08:21:21PM +0100, Adrian Bunk wrote:
> On Fri, Nov 19, 2004 at 05:03:29AM -0500, Manfred Schwarb wrote:
> > Hi,
> >
> > OK, I know I'm stupid...
> > I always forget to unset my GZIP options, as I have
> > "export GZIP='-9 -N'" in my .bashrc.
> >
> > This results in the following:
> >
> > objcopy -Iihex pca200e.data -Obinary pca200e.bin.gz
> > gzip -df pca200e.bin.gz
> > ./fore200e_mkfirm -k -b _fore200e_pca_fw \
> > -i pca200e.bin -o fore200e_pca_fw.c
> > ./fore200e_mkfirm: can't open pca200e.bin for reading
> > make[2]: *** [fore200e_pca_fw.c] Error 254
> > make[2]: Leaving directory `/usr/src/linux-2.4.28/drivers/atm'
> > make[1]: *** [_modsubdir_atm] Error 2
> > make[1]: Leaving directory `/usr/src/linux-2.4.28/drivers'
> > make: *** [_mod_drivers] Error 2
> >
> >
> > The following patch would correct this:
> >
> > --- linux-2.4.28/drivers/atm/Makefile.orig 2004-11-19 09:33:21.000000000 +0000
> > +++ linux-2.4.28/drivers/atm/Makefile 2004-11-19 09:38:07.000000000 +0000
> > @@ -92,7 +92,7 @@
> > # deal with the various suffixes of the binary firmware images
> > %.bin %.bin1 %.bin2: %.data
> > objcopy -Iihex $< -Obinary $@.gz
> > - gzip -df $@.gz
> > + gzip -n -df $@.gz
> >
> > fore_200e.o: $(fore_200e-objs)
> > $(LD) -r -o $@ $(fore_200e-objs)
>
>
> I have no problems with this patch, but shouldn't the same be done
> in 2.6?
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.10-rc2-mm3-full/drivers/atm/Makefile.old 2004-11-28 20:18:04.000000000 +0100
> +++ linux-2.6.10-rc2-mm3-full/drivers/atm/Makefile 2004-11-28 20:18:15.000000000 +0100
> @@ -68,4 +68,4 @@
> # deal with the various suffixes of the binary firmware images
> $(obj)/%.bin $(obj)/%.bin1 $(obj)/%.bin2: $(src)/%.data
> objcopy -Iihex $< -Obinary $@.gz
> - gzip -df $@.gz
> + gzip -n -df $@.gz
Isnt it exactly the same of what has been merged in v2.4?
I can't see any difference.
[marcelo@dmt atm]$ bk diffs -u -r1.8 -r1.9 Makefile
===== Makefile 1.8 vs 1.9 =====
--- 1.8/drivers/atm/Makefile Mon Jul 28 11:35:31 2003
+++ 1.9/drivers/atm/Makefile Mon Nov 22 21:54:09 2004
@@ -92,7 +92,7 @@
# deal with the various suffixes of the binary firmware images
%.bin %.bin1 %.bin2: %.data
objcopy -Iihex $< -Obinary $@.gz
- gzip -df $@.gz
+ gzip -n -df $@.gz
fore_200e.o: $(fore_200e-objs)
$(LD) -r -o $@ $(fore_200e-objs)
next prev parent reply other threads:[~2004-12-01 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 10:03 [2.4.28] Build Error 2: build of pca200e.bin fails Manfred Schwarb
2004-11-28 19:21 ` [2.6 patch] " Adrian Bunk
2004-11-30 17:00 ` Marcelo Tosatti [this message]
2004-12-01 2:36 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130170031.GD5009@dmt.cyclades \
--to=marcelo.tosatti@cyclades.com \
--cc=bunk@stusta.de \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred99@gmx.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.