From: Domen Puncer <domen@coderock.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: janitor@sternwelten.at, linux-kernel@vger.kernel.org, akpm@digeo.com
Subject: Re: ds1620: replace schedule_timeout() with msleep()
Date: Mon, 29 Nov 2004 15:09:30 +0100 [thread overview]
Message-ID: <20041129140929.GC7889@nd47.coderock.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0411281835430.3389@dragon.hygekrogen.localhost>
On 28/11/04 18:39 +0100, Jesper Juhl wrote:
> > +++ linux-2.6.9-rc1-bk7-max/drivers/char/ds1620.c 2004-09-01 19:34:43.000000000 +0200
> > @@ -373,8 +373,7 @@ static int __init ds1620_init(void)
> > th_start.hi = 1;
> > ds1620_write_state(&th_start);
> >
> > - set_current_state(TASK_INTERRUPTIBLE);
> > - schedule_timeout(2*HZ);
> > + msleep(2000);
> >
> > ds1620_write_state(&th);
> >
> I'm wondering if 2000 is really the value we want here. As far as I can
> see, the schedule_timeout(2*HZ); line has been there as long back as
> since HZ was 100, so back then the delay would have been 200. if 200 is
> all it needs, then we are now sleeping 10 times as long as really needed.
> What is the argument behind the value used?
It's right:
schedule_timeout(2*HZ) sleeps for 2 seconds;
msleep(2000) sleeps for 2000 miliseconds, and does not depend on what
HZ is.
Domen
next prev parent reply other threads:[~2004-11-29 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 20:57 [patch 18/25] ds1620: replace schedule_timeout() with msleep() janitor
2004-11-28 17:39 ` Jesper Juhl
2004-11-29 14:09 ` Domen Puncer [this message]
2004-11-29 22:37 ` Jesper Juhl
2004-11-29 22:42 ` Russell King
2004-11-30 0:10 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041129140929.GC7889@nd47.coderock.org \
--to=domen@coderock.org \
--cc=akpm@digeo.com \
--cc=janitor@sternwelten.at \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.