From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Domen Puncer <domen@coderock.org>,
janitor@sternwelten.at, linux-kernel@vger.kernel.org,
akpm@digeo.com
Subject: Re: ds1620: replace schedule_timeout() with msleep()
Date: Mon, 29 Nov 2004 22:42:40 +0000 [thread overview]
Message-ID: <20041129224240.D5614@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0411292336320.3389@dragon.hygekrogen.localhost>; from juhl-lkml@dif.dk on Mon, Nov 29, 2004 at 11:37:48PM +0100
On Mon, Nov 29, 2004 at 11:37:48PM +0100, Jesper Juhl wrote:
> On Mon, 29 Nov 2004, Domen Puncer wrote:
> > It's right:
> > schedule_timeout(2*HZ) sleeps for 2 seconds;
> > msleep(2000) sleeps for 2000 miliseconds, and does not depend on what
> > HZ is.
>
> It seems I didn't understand schedule_timeout() properly, thank you for
> the clarification.
As part-author of this driver, and actually of this particular bit
of code, a 2 second delay is intented here. The fan needs to be run
at full power in order to start running, so the idea here is to give
it full power for 2 seconds and then to restore the temperature trip
points to the configured values.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-11-29 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 20:57 [patch 18/25] ds1620: replace schedule_timeout() with msleep() janitor
2004-11-28 17:39 ` Jesper Juhl
2004-11-29 14:09 ` Domen Puncer
2004-11-29 22:37 ` Jesper Juhl
2004-11-29 22:42 ` Russell King [this message]
2004-11-30 0:10 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041129224240.D5614@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@digeo.com \
--cc=domen@coderock.org \
--cc=janitor@sternwelten.at \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.