All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Joshua Kwan <joshk@triplehelix.org>
Cc: gandalf@wlug.westbo.se, torvalds@osdl.org,
	linux-kernel@vger.kernel.org, alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix ALSA resume
Date: Sat, 4 Dec 2004 23:51:55 -0800	[thread overview]
Message-ID: <20041204235155.3b8ad3fc.akpm@osdl.org> (raw)
In-Reply-To: <41B282F0.3020704@triplehelix.org>

Joshua Kwan <joshk@triplehelix.org> wrote:
>
> Andrew Morton wrote:
> > But Joshua crosses his heart and swears that the pci_disable_device() is
> > also needed for a successful swsusp resume.
> 
> I never said I had any problems with resuming.

OK, suspend was failing, yes?

> That said, I tried removing the pci_disable_device call and things seem
> to still work. So I guess it can be left out?

Can you please test Martin's patch?


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Joshua Kwan <joshk@triplehelix.org>
Cc: gandalf@wlug.westbo.se, torvalds@osdl.org,
	linux-kernel@vger.kernel.org, alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix ALSA resume
Date: Sat, 4 Dec 2004 23:51:55 -0800	[thread overview]
Message-ID: <20041204235155.3b8ad3fc.akpm@osdl.org> (raw)
In-Reply-To: <41B282F0.3020704@triplehelix.org>

Joshua Kwan <joshk@triplehelix.org> wrote:
>
> Andrew Morton wrote:
> > But Joshua crosses his heart and swears that the pci_disable_device() is
> > also needed for a successful swsusp resume.
> 
> I never said I had any problems with resuming.

OK, suspend was failing, yes?

> That said, I tried removing the pci_disable_device call and things seem
> to still work. So I guess it can be left out?

Can you please test Martin's patch?

  reply	other threads:[~2004-12-05  7:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-04 21:23 [PATCH] Fix ALSA resume Martin Josefsson
2004-12-04 21:54 ` Lee Revell
2004-12-04 21:54   ` Lee Revell
2004-12-05  1:28 ` Andrew Morton
2004-12-05  1:28   ` Andrew Morton
2004-12-05  3:39   ` Joshua Kwan
2004-12-05  3:39     ` Joshua Kwan
2004-12-05  7:51     ` Andrew Morton [this message]
2004-12-05  7:51       ` Andrew Morton
2004-12-05 10:06       ` Joshua Kwan
2004-12-05 10:06         ` Joshua Kwan
2004-12-05 12:11         ` Martin Josefsson
2004-12-06 14:22   ` Takashi Iwai
2004-12-06 14:22     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041204235155.3b8ad3fc.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=gandalf@wlug.westbo.se \
    --cc=joshk@triplehelix.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.