From: Adrian Bunk <bunk@stusta.de>
To: Riina Kikas <riinak@ut.ee>
Cc: linux-kernel@vger.kernel.org, mroos@ut.ee
Subject: Re: [PATCH 2.6] clean-up: fixes "shadows global", "unused parameter" warnings
Date: Mon, 6 Dec 2004 22:38:59 +0100 [thread overview]
Message-ID: <20041206213859.GK7250@stusta.de> (raw)
In-Reply-To: <Pine.SOC.4.61.0412062253040.21075@math.ut.ee>
On Mon, Dec 06, 2004 at 10:55:11PM +0200, Riina Kikas wrote:
> This patch fixes warnings "declaration of `prefetch' shadows a global
> declaration"
> (occuring on line 141) and "unused parameter `addr'" (occuring on line 136)
>
> Signed-off-by: Riina Kikas <Riina.Kikas@mail.ee>
>
> --- a/arch/i386/mm/fault.c 2004-12-02 21:30:30.000000000 +0000
> +++ b/arch/i386/mm/fault.c 2004-12-02 21:30:59.000000000 +0000
> @@ -133,12 +133,12 @@
> * Sometimes AMD Athlon/Opteron CPUs report invalid exceptions on prefetch.
> * Check that here and ignore it.
> */
> -static int __is_prefetch(struct pt_regs *regs, unsigned long addr)
> +static int __is_prefetch(struct pt_regs *regs)
>...
> static inline int is_prefetch(struct pt_regs *regs, unsigned long
I wonder how this patch compiled for you considering that you didn't
change the call to __is_prefetch in is_prefetch...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-12-06 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 20:55 [PATCH 2.6] clean-up: fixes "shadows global", "unused parameter" warnings Riina Kikas
2004-12-06 21:38 ` Adrian Bunk [this message]
2004-12-06 21:47 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041206213859.GK7250@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@ut.ee \
--cc=riinak@ut.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.