All of lore.kernel.org
 help / color / mirror / Atom feed
From: Riina Kikas <riinak@ut.ee>
To: linux-kernel@vger.kernel.org
Cc: mroos@ut.ee
Subject: [PATCH 2.6] clean-up: fixes "shadows global", "unused parameter" warnings
Date: Mon, 6 Dec 2004 22:55:11 +0200 (EET)	[thread overview]
Message-ID: <Pine.SOC.4.61.0412062253040.21075@math.ut.ee> (raw)

This patch fixes warnings "declaration of `prefetch' shadows a global declaration"
(occuring on line 141) and "unused parameter `addr'" (occuring on line 136)

Signed-off-by: Riina Kikas <Riina.Kikas@mail.ee>

--- a/arch/i386/mm/fault.c	2004-12-02 21:30:30.000000000 +0000
+++ b/arch/i386/mm/fault.c	2004-12-02 21:30:59.000000000 +0000
@@ -133,12 +133,12 @@
   * Sometimes AMD Athlon/Opteron CPUs report invalid exceptions on prefetch.
   * Check that here and ignore it.
   */
-static int __is_prefetch(struct pt_regs *regs, unsigned long addr)
+static int __is_prefetch(struct pt_regs *regs)
  {
  	unsigned long limit;
  	unsigned long instr = get_segment_eip (regs, &limit);
  	int scan_more = 1;
-	int prefetch = 0; 
+	int really_prefetch = 0;
  	int i;

  	for (i = 0; scan_more && i < 15; i++) { 
@@ -177,7 +177,7 @@
  				break;
  			if (__get_user(opcode, (unsigned char *) instr))
  				break;
-			prefetch = (instr_lo == 0xF) &&
+			really_prefetch = (instr_lo == 0xF) &&
  				(opcode == 0x0D || opcode == 0x18);
  			break;
  		default:
@@ -185,7 +185,7 @@
  			break;
  		}
  	}
-	return prefetch;
+	return really_prefetch;
  }

  static inline int is_prefetch(struct pt_regs *regs, unsigned long addr,

             reply	other threads:[~2004-12-06 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-06 20:55 Riina Kikas [this message]
2004-12-06 21:38 ` [PATCH 2.6] clean-up: fixes "shadows global", "unused parameter" warnings Adrian Bunk
2004-12-06 21:47 ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SOC.4.61.0412062253040.21075@math.ut.ee \
    --to=riinak@ut.ee \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@ut.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.