All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Kirby <sim@netnation.com>
To: Pablo Neira <pablo@eurodev.net>
Cc: Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>,
	Krzysztof Oledzki <ole@ans.pl>
Subject: Re: REJECT using invalid data
Date: Tue, 7 Dec 2004 16:52:16 -0800	[thread overview]
Message-ID: <20041208005216.GA7958@netnation.com> (raw)
In-Reply-To: <41B642A1.9030807@eurodev.net>

On Wed, Dec 08, 2004 at 12:54:09AM +0100, Pablo Neira wrote:

> >And what about other protocols (udp, etc) when REJECT
> >generates ICMP port-unreachable?
> 
> you are right, udp stuff is missing, checkings here are trivial to add 
> anyway. I'll think about this issue more carefully in next days.

I don't think it's a good idea to try to filter all TCP flags in REJECT
unless we're trying to avoid rejecting rejects and we don't already do
that for some reason (eep), for the same reason that unclean was removed
(ECN and other new functionality could break).  I would think that all
that is needed is a check for the RST bit.

At the same time, it would be nice to have a match (or at least some
functionality) resulting in the ability to drop corrupted packets
("corrupted" as in with the checksum) that would otherwise be accepted. 

Hmm.  Maybe this should be done at a different level?  It should
basically not match "-p tcp" in the rule "iptables -p tcp -j REJECT". 
Doing it at "-p tcp" time would also correct "iptables -p tcp --dport 80
-j ACCEPT", which would otherwise also be affected by the same problem
(the TCP port could be corrupted).

Simon-

  parent reply	other threads:[~2004-12-08  0:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.53.0412072347080.2736@bizon.gios.gov.pl>
2004-12-07 23:54 ` REJECT using invalid data Pablo Neira
2004-12-08  0:33   ` Krzysztof Oledzki
2004-12-08  0:52   ` Simon Kirby [this message]
     [not found]     ` <Pine.LNX.4.53.0412101310210.1288@bizon.gios.gov.pl>
2004-12-10 13:10       ` Simon Kirby
     [not found]         ` <Pine.LNX.4.53.0412101439530.6072@bizon.gios.gov.pl>
2004-12-10 14:49           ` Simon Kirby
2004-12-07  1:01 Simon Kirby
2004-12-07 11:07 ` Pablo Neira
2004-12-07 17:28   ` Simon Kirby
2004-12-07 22:14     ` Pablo Neira
2004-12-08  2:47       ` Kiran Kumar Immidi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041208005216.GA7958@netnation.com \
    --to=sim@netnation.com \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=ole@ans.pl \
    --cc=pablo@eurodev.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.