From: Kiran Kumar Immidi <immidi@spymac.com>
To: Pablo Neira <pablo@eurodev.net>, Simon Kirby <sim@netnation.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: REJECT using invalid data
Date: Wed, 8 Dec 2004 08:17:35 +0530 [thread overview]
Message-ID: <200412080817.35575.immidi@spymac.com> (raw)
In-Reply-To: <41B62B54.8060003@eurodev.net>
On Wednesday 08 December 2004 03:44, Pablo Neira wrote:
>Now I see, if state tracking is not enable there's no way to avoid this
>problem. But I guess that we should drop all malformed packets, not only
>those which have bad checksums. Would you like to give a try to the
>patch attached?
Just a comment on this;
+static u8 tcp_valid_flags[(TH_FIN|TH_SYN|TH_RST|TH_PUSH|TH_ACK|TH_URG) + 1] =
This makes the array about 64 bytes long, would be better to store as an
array of valid flags rather than as a bit mask;
--
Regards,
Kiran Kumar Immidi
next prev parent reply other threads:[~2004-12-08 2:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-07 1:01 REJECT using invalid data Simon Kirby
2004-12-07 11:07 ` Pablo Neira
2004-12-07 17:28 ` Simon Kirby
2004-12-07 22:14 ` Pablo Neira
2004-12-08 2:47 ` Kiran Kumar Immidi [this message]
[not found] <Pine.LNX.4.53.0412072347080.2736@bizon.gios.gov.pl>
2004-12-07 23:54 ` Pablo Neira
2004-12-08 0:33 ` Krzysztof Oledzki
2004-12-08 0:52 ` Simon Kirby
[not found] ` <Pine.LNX.4.53.0412101310210.1288@bizon.gios.gov.pl>
2004-12-10 13:10 ` Simon Kirby
[not found] ` <Pine.LNX.4.53.0412101439530.6072@bizon.gios.gov.pl>
2004-12-10 14:49 ` Simon Kirby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412080817.35575.immidi@spymac.com \
--to=immidi@spymac.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
--cc=sim@netnation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.