[PATCH] Compile 6xx specific code only for 6xx machines

[PATCH] Compile 6xx specific code only for 6xx machines

[tglx]

The 6xx specific mmu functions in arch/boot/common/util.S break the compile for
other platforms. Compile them for 6xx only.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 util.S |    2 ++
 1 files changed, 2 insertions(+)
---
Index: 2.6.10-rc3/arch/ppc/boot/common/util.S
===================================================================
--- 2.6.10-rc3/arch/ppc/boot/common/util.S	(revision 11)
+++ 2.6.10-rc3/arch/ppc/boot/common/util.S	(working copy)
@@ -27,6 +27,7 @@
 
 	.text
 
+#ifdef CONFIG_6xx
 	.globl	disable_6xx_mmu
 disable_6xx_mmu:
 	/* Establish default MSR value, exception prefix 0xFFF.
@@ -94,6 +95,7 @@
 	sync
 	isync
 	blr
+#endif
 
 	.globl	_setup_L2CR
 _setup_L2CR:

Re: [PATCH] Compile 6xx specific code only for 6xx machines

[Tom Rini]

On Wed, Dec 15, 2004 at 03:21:43PM +0100, tglx@linutronix.de wrote:

> The 6xx specific mmu functions in arch/boot/common/util.S break the compile for
> other platforms. Compile them for 6xx only.

They, er, do?  Can you please post a log?  And what toolchain are you
using?  I'd make a quick guess that the binutils folks are being overly
'helpful' again, but perhaps I'm just jaded. :)

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: [PATCH] Compile 6xx specific code only for 6xx machines

[Thomas Gleixner]

On Wed, 2004-12-15 at 07:35 -0700, Tom Rini wrote:
> On Wed, Dec 15, 2004 at 03:21:43PM +0100, tglx@linutronix.de wrote:
> 
> > The 6xx specific mmu functions in arch/boot/common/util.S break the compile for
> > other platforms. Compile them for 6xx only.
> 
> They, er, do?  Can you please post a log?  And what toolchain are you
> using?  I'd make a quick guess that the binutils folks are being overly
> 'helpful' again, but perhaps I'm just jaded. :)

I'm compiling for 8540 (e500)

  AS      arch/ppc/boot/common/util.o
/home/tglx/work/repos/linux-ebrain/2.6.10-
rc3/arch/ppc/boot/common/util.S: Assembler messages:
/home/tglx/work/repos/linux-ebrain/2.6.10-
rc3/arch/ppc/boot/common/util.S:76: Error: Unrecognized opcode: `mtsrin'
make[3]: *** [arch/ppc/boot/common/util.o] Error 1
make[2]: *** [arch/ppc/boot/common] Error 2
make[1]: *** [zImage] Error 2
make: *** [_all] Error 2

Toolchain is built with crosstool

binutils-2.15
gcc-3.4.2
glibc-2.3.3

tglx

Re: [PATCH] Compile 6xx specific code only for 6xx machines

[Kumar Gala]

One reason for this is that we dont have boot/common code for e500.  Up=20=

to this point we've been using uImage's which causes code in=20
boot/common not to get built.

Maybe someone will be motivated to right e500/85xx boot/common code :)

- kumar

On Dec 15, 2004, at 8:49 AM, Thomas Gleixner wrote:

> On Wed, 2004-12-15 at 07:35 -0700, Tom Rini wrote:
>  > On Wed, Dec 15, 2004 at 03:21:43PM +0100, tglx@linutronix.de wrote:
>  >
> > > The 6xx specific mmu functions in arch/boot/common/util.S break=20
> the compile for
>  > > other platforms. Compile them for 6xx only.
>  >
> > They, er, do?=A0 Can you please post a log?=A0 And what toolchain =
are you
>  > using?=A0 I'd make a quick guess that the binutils folks are being=20=

> overly
>  > 'helpful' again, but perhaps I'm just jaded. :)
>
> I'm compiling for 8540 (e500)
>
> =A0 AS=A0=A0=A0=A0=A0 arch/ppc/boot/common/util.o
> /home/tglx/work/repos/linux-ebrain/2.6.10-
>  rc3/arch/ppc/boot/common/util.S: Assembler messages:
>  /home/tglx/work/repos/linux-ebrain/2.6.10-
>  rc3/arch/ppc/boot/common/util.S:76: Error: Unrecognized opcode:=20
> `mtsrin'
>  make[3]: *** [arch/ppc/boot/common/util.o] Error 1
>  make[2]: *** [arch/ppc/boot/common] Error 2
>  make[1]: *** [zImage] Error 2
>  make: *** [_all] Error 2
>
> Toolchain is built with crosstool
>
> binutils-2.15
>  gcc-3.4.2
>  glibc-2.3.3
>
> tglx
>
>
>
> _______________________________________________
> Linuxppc-embedded mailing list
>  Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Re: [PATCH] Compile 6xx specific code only for 6xx machines

[Thomas Gleixner]

On Wed, 2004-12-15 at 09:15 -0600, Kumar Gala wrote:
> One reason for this is that we dont have boot/common code for e500.  Up 
> to this point we've been using uImage's which causes code in 
> boot/common not to get built.
> 
> Maybe someone will be motivated to right e500/85xx boot/common code :)
> 
> - kumar

By adding this fix I can use the code in boot/simple. It works nice :)

tglx