All of lore.kernel.org
 help / color / mirror / Atom feed
* minor asm-mips/sigcontext.h fix
@ 2004-12-16 10:37 Atsushi Nemoto
  2004-12-16 13:21 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2004-12-16 10:37 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

The asm-mips/sigcontext.h uses '#ifdef __KERNEL__' to not export
sigcontext32 to userland.  It includes linux/types.h but it is needed
just for sigcontext32, so it would be better to hide from userland
too.

Here is a patch.  Could you apply?

--- linux-mips/include/asm-mips/sigcontext.h	2004-08-14 19:56:24.000000000 +0900
+++ linux/include/asm-mips/sigcontext.h	2004-12-16 19:02:43.922237317 +0900
@@ -41,8 +41,6 @@
                                                                                 
 #if _MIPS_SIM == _MIPS_SIM_ABI64 || _MIPS_SIM == _MIPS_SIM_NABI32
 
-#include <linux/types.h>
-
 /*
  * Keep this struct definition in sync with the sigcontext fragment
  * in arch/mips/tools/offset.c
@@ -66,6 +64,8 @@
 };
 
 #ifdef __KERNEL__
+#include <linux/types.h>
+
 struct sigcontext32 {
 	__u32	sc_regmask;		/* Unused */
 	__u32	sc_status;

---
Atsushi Nemoto

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: minor asm-mips/sigcontext.h fix
  2004-12-16 10:37 minor asm-mips/sigcontext.h fix Atsushi Nemoto
@ 2004-12-16 13:21 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2004-12-16 13:21 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-mips

On Thu, Dec 16, 2004 at 07:37:58PM +0900, Atsushi Nemoto wrote:

> The asm-mips/sigcontext.h uses '#ifdef __KERNEL__' to not export
> sigcontext32 to userland.  It includes linux/types.h but it is needed
> just for sigcontext32, so it would be better to hide from userland
> too.
> 
> Here is a patch.  Could you apply?

Applied but changed to include <linux/posix_types.h> only.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-12-16 13:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-16 10:37 minor asm-mips/sigcontext.h fix Atsushi Nemoto
2004-12-16 13:21 ` Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.