From: Christoph Hellwig <hch@infradead.org>
To: Pat Gefre <pfg@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6.10 Altix : ioc4 serial driver support
Date: Thu, 16 Dec 2004 23:15:19 +0000 [thread overview]
Message-ID: <20041216231519.GA16249@infradead.org> (raw)
In-Reply-To: <200412162224.iBGMOQ52284713@fsgi900.americas.sgi.com>
On Thu, Dec 16, 2004 at 04:24:26PM -0600, Pat Gefre wrote:
> I have a serial driver for Altix I'd like to submit.
>
> The code is at:
> ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support
>
> Signed-off-by: Patrick Gefre <pfg@sgi.com>
I took a very short look and what spring to mind first is that the
device probing/remoal is rather bogus. The ->probe/->remove callbacks
of a PCI driver can be called at any time, and any initialization /
teardown actions must happen from those. A logical consequence of that
is that a proper PCI driver should have no global state.
I'd also like to second Matthews commens, please move the driver to
drivers/serial and use proper readX/writeX accessors. Please run the
driver through sparse to find the iomem derferences and possibly other
issues.
next prev parent reply other threads:[~2004-12-16 23:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 22:24 [PATCH] 2.6.10 Altix : ioc4 serial driver support Pat Gefre
2004-12-16 22:24 ` Pat Gefre
2004-12-16 22:43 ` Matthew Wilcox
2004-12-16 23:15 ` Christoph Hellwig [this message]
2004-12-17 16:24 ` Matthew Wilcox
2004-12-17 22:14 ` Patrick Gefre
2004-12-17 22:14 ` Patrick Gefre
2004-12-18 14:51 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-12-22 0:28 Pat Gefre
2004-12-22 13:44 ` Christoph Hellwig
2004-12-22 14:03 ` Russell King
2004-12-22 15:20 ` Patrick Gefre
2004-12-22 18:49 ` Russell King
2004-12-22 19:53 ` Patrick Gefre
2004-12-22 20:33 ` Matthew Wilcox
2005-01-03 14:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041216231519.GA16249@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.