From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>, Pat Gefre <pfg@sgi.com>,
linux-kernel@vger.kernel.org, matthew@wil.cx
Subject: Re: [PATCH] 2.6.10 Altix : ioc4 serial driver support
Date: Wed, 22 Dec 2004 14:03:48 +0000 [thread overview]
Message-ID: <20041222140348.A1130@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20041222134423.GA11750@infradead.org>; from hch@infradead.org on Wed, Dec 22, 2004 at 01:44:23PM +0000
On Wed, Dec 22, 2004 at 01:44:23PM +0000, Christoph Hellwig wrote:
> > I still save off the pci_dev ptrs for all cards found, so I can
> > register with the serial core after probe (is there a better way?).
> > Should I register the driver separately for each card ? That seems a
> > bit overkill.
>
> You should register them with the serial core in ->probe.
You want to register with the serial core before you register with PCI.
Then add each port when you find it via the PCI driver ->probe method.
Removal is precisely the reverse order - remove each port in ->remove
method first, then unregister from serial core.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-12-22 14:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-22 0:28 [PATCH] 2.6.10 Altix : ioc4 serial driver support Pat Gefre
2004-12-22 13:44 ` Christoph Hellwig
2004-12-22 14:03 ` Russell King [this message]
2004-12-22 15:20 ` Patrick Gefre
2004-12-22 18:49 ` Russell King
2004-12-22 19:53 ` Patrick Gefre
2004-12-22 20:33 ` Matthew Wilcox
2005-01-03 14:09 ` Christoph Hellwig
2005-01-31 22:45 ` [PATCH] " Pat Gefre
2005-02-01 9:23 ` Christoph Hellwig
2005-02-02 20:36 ` Patrick Gefre
2005-02-02 21:37 ` Bartlomiej Zolnierkiewicz
2005-02-02 21:57 ` Christoph Hellwig
2005-02-07 15:58 ` Patrick Gefre
2005-02-07 16:25 ` Christoph Hellwig
2005-02-08 16:52 ` Patrick Gefre
2005-02-08 19:32 ` Patrick Gefre
2005-02-10 19:09 ` Jesse Barnes
2005-02-10 19:15 ` Christoph Hellwig
2005-02-10 21:07 ` Patrick Gefre
2005-02-17 21:55 ` Patrick Gefre
-- strict thread matches above, loose matches on Subject: below --
2004-12-16 22:24 [PATCH] 2.6.10 " Pat Gefre
2004-12-16 22:24 ` Pat Gefre
2004-12-16 22:43 ` Matthew Wilcox
2004-12-16 23:15 ` Christoph Hellwig
2004-12-17 16:24 ` Matthew Wilcox
2004-12-17 22:14 ` Patrick Gefre
2004-12-17 22:14 ` Patrick Gefre
2004-12-18 14:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041222140348.A1130@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.