From: Patrick Gefre <pfg@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, matthew@wil.cx,
B.Zolnierkiewicz@elka.pw.edu.pl
Subject: Re: [PATCH] Altix : ioc4 serial driver support
Date: Mon, 07 Feb 2005 09:58:33 -0600 [thread overview]
Message-ID: <42079029.5040401@sgi.com> (raw)
In-Reply-To: <20050202215716.GA23253@infradead.org>
Christoph Hellwig wrote:
> On Wed, Feb 02, 2005 at 02:36:15PM -0600, Patrick Gefre wrote:
>
>>>Please kill ioc4_ide_init as it's completely unused and make
>>>ioc4_serial_init
>>>a normal module_init() handler in ioc4_serial, there's no need to call
>>>them from the generic driver.
>>>
>>
>>I want ioc4_serial_init called before pci_register_driver() if I make it a
>>module_init() call I have no control over order ??
>
>
> For the modular case it'd always be executed before because the module
> must be loaded first, for the builtin case it'd depend on the link order.
>
> Let's leave it as-is, it's probably safer.
>
>
Latest version with review mods:
ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support
Signed-off-by: Patrick Gefre <pfg@sgi.com>
next prev parent reply other threads:[~2005-02-07 16:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-22 0:28 [PATCH] 2.6.10 Altix : ioc4 serial driver support Pat Gefre
2004-12-22 13:44 ` Christoph Hellwig
2004-12-22 14:03 ` Russell King
2004-12-22 15:20 ` Patrick Gefre
2004-12-22 18:49 ` Russell King
2004-12-22 19:53 ` Patrick Gefre
2004-12-22 20:33 ` Matthew Wilcox
2005-01-03 14:09 ` Christoph Hellwig
2005-01-31 22:45 ` [PATCH] " Pat Gefre
2005-02-01 9:23 ` Christoph Hellwig
2005-02-02 20:36 ` Patrick Gefre
2005-02-02 21:37 ` Bartlomiej Zolnierkiewicz
2005-02-02 21:57 ` Christoph Hellwig
2005-02-07 15:58 ` Patrick Gefre [this message]
2005-02-07 16:25 ` Christoph Hellwig
2005-02-08 16:52 ` Patrick Gefre
2005-02-08 19:32 ` Patrick Gefre
2005-02-10 19:09 ` Jesse Barnes
2005-02-10 19:15 ` Christoph Hellwig
2005-02-10 21:07 ` Patrick Gefre
2005-02-17 21:55 ` Patrick Gefre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42079029.5040401@sgi.com \
--to=pfg@sgi.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.