From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: kernel-2.6.9: make sock_init() notice errors
Date: Sat, 18 Dec 2004 09:58:56 +0000 [thread overview]
Message-ID: <20041218095856.GA3754@masina.coderock.org> (raw)
In-Reply-To: <20041215160106.GA5321@nd47.coderock.org>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On 15/12/04 18:27 +0100, walter harms wrote:
>
> Hi domen, hi list,
>
> its true that the user can not do much about missing memmory but he
> should know WHAT error occured.
> NTL not checking returncodes is an error.
> Continuing when one earlier function did not work is also an error and
> may cause problems in unexspected places.
> Since this is an init code its no performance consideration to be made.
Ok, fair enough; if you fix whitespace i'll include it.
>
> re,
> walter
>
>
>
> Domen Puncer wrote:
> >Also, there's still whitespace damage like:
> >
> >>+ ret=init_inodecache();
> >>+ if ( ret < 0 ) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-12-18 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-15 16:01 [KJ] Re: kernel-2.6.9: make sock_init() notice errors Domen Puncer
2004-12-15 17:27 ` walter harms
2004-12-15 21:45 ` Arnaldo Carvalho de Melo
2004-12-18 9:58 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041218095856.GA3754@masina.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.