From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] Re: kernel-2.6.9: make sock_init() notice errors
Date: Wed, 15 Dec 2004 21:45:31 +0000 [thread overview]
Message-ID: <41C0B07B.50208@conectiva.com.br> (raw)
In-Reply-To: <20041215160106.GA5321@nd47.coderock.org>
Domen Puncer wrote:
> On 27/11/04 17:26 +0100, walter harms wrote:
>
>>Hi list,
>>by accident i found that that sock_init never checks the return code of
>>called init functions. I have no idea why this is not done so i added
>>only a printk() to inform the user about the problem.
>>The function returns no error indicator. i left it this way.
>
>
> I don't like this patch: it doesn't really do anything useful...
> ie. if user runs out of memory on boot, he'll have other problems
> than caring about sock_init failing somewhere.
>
> Comments?
Better have a message that gives a clue about where things went wrong
than nothing.
If a function is not to be checked against failure, convert it to
return void 8) IOW: always check non void returning functions.
- Arnaldo
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-12-15 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-15 16:01 [KJ] Re: kernel-2.6.9: make sock_init() notice errors Domen Puncer
2004-12-15 17:27 ` walter harms
2004-12-15 21:45 ` Arnaldo Carvalho de Melo [this message]
2004-12-18 9:58 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C0B07B.50208@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.