From: Adrian Bunk <bunk@stusta.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
bluez-devel@lists.sf.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Network Development Mailing List <netdev@oss.sgi.com>
Subject: Re: [2.6 patch] net/bluetooth/: misc possible cleanups
Date: Sun, 19 Dec 2004 17:07:58 +0100 [thread overview]
Message-ID: <20041219160758.GY21288@stusta.de> (raw)
In-Reply-To: <1103009649.2143.65.camel@pegasus>
On Tue, Dec 14, 2004 at 08:34:08AM +0100, Marcel Holtmann wrote:
> Hi Adrian,
Hi Marcel,
>...
> > Please comment on which of these changes are correct and which conflict
> > with pending patches.
>
> Please send a separate patch for all the RFCOMM changes, because these
> conflicts with some pending patches and then it will make it easier for
> me to merge them.
>
> The rest of the changes are fine with me, but I like to see also a
> separate patch for the CMTP stuff and cmtp_send_capimsg() don't need a
> forward declaration. Simply move the function to another place in the
> source code.
splitted patches follow as reply to this email.
> Regards
>
> Marcel
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
bluez-devel@lists.sf.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Network Development Mailing List <netdev@oss.sgi.com>
Subject: Re: [2.6 patch] net/bluetooth/: misc possible cleanups
Date: Sun, 19 Dec 2004 17:07:58 +0100 [thread overview]
Message-ID: <20041219160758.GY21288@stusta.de> (raw)
In-Reply-To: <1103009649.2143.65.camel@pegasus>
On Tue, Dec 14, 2004 at 08:34:08AM +0100, Marcel Holtmann wrote:
> Hi Adrian,
Hi Marcel,
>...
> > Please comment on which of these changes are correct and which conflict
> > with pending patches.
>
> Please send a separate patch for all the RFCOMM changes, because these
> conflicts with some pending patches and then it will make it easier for
> me to merge them.
>
> The rest of the changes are fine with me, but I like to see also a
> separate patch for the CMTP stuff and cmtp_send_capimsg() don't need a
> forward declaration. Simply move the function to another place in the
> source code.
splitted patches follow as reply to this email.
> Regards
>
> Marcel
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
next prev parent reply other threads:[~2004-12-19 16:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-14 4:13 [2.6 patch] net/bluetooth/: misc possible cleanups Adrian Bunk
2004-12-14 4:13 ` Adrian Bunk
2004-12-14 7:34 ` Marcel Holtmann
2004-12-14 7:34 ` Marcel Holtmann
2004-12-14 7:34 ` Marcel Holtmann
2004-12-14 9:45 ` Christoph Hellwig
2004-12-14 9:45 ` Christoph Hellwig
2004-12-14 9:54 ` Marcel Holtmann
2004-12-14 9:54 ` Marcel Holtmann
2004-12-19 16:07 ` Adrian Bunk [this message]
2004-12-19 16:07 ` Adrian Bunk
2004-12-19 16:13 ` [2.6 patch] bluetooth/rfcomm/: make some code static Adrian Bunk
2004-12-19 16:13 ` Adrian Bunk
2004-12-19 16:34 ` [2.6 patch] bluetooth/cmtp/capi.c: make a function static Adrian Bunk
2004-12-19 16:34 ` Adrian Bunk
2004-12-19 16:34 ` [2.6 patch] bluetooth: make some code static Adrian Bunk
2004-12-19 16:34 ` Adrian Bunk
2004-12-26 11:20 ` [2.6 patch] net/bluetooth/: misc possible cleanups Marcel Holtmann
2004-12-26 11:20 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041219160758.GY21288@stusta.de \
--to=bunk@stusta.de \
--cc=bluez-devel@lists.sf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.