All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Art Haas" <ahaas@airmail.net>
To: Andrew Morton <akpm@osdl.org>,
	Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
	linux-ide@vger.kernel.org
Subject: [PATCH] Small initializer patch for ide-disk.c
Date: Tue, 21 Dec 2004 14:24:07 -0600	[thread overview]
Message-ID: <20041221202407.GD2725@artsapartment.org> (raw)

Hi.

This patch adds C99 initializers to the file. It can clearly wait until
after 2.6.10 is released if you want to send it to Linus.

Art Haas

===== drivers/ide/ide-disk.c 1.109 vs edited =====
--- 1.109/drivers/ide/ide-disk.c	2004-11-06 19:55:34 -06:00
+++ edited/drivers/ide/ide-disk.c	2004-12-20 17:24:38 -06:00
@@ -871,11 +871,27 @@
 }
 
 static ide_proc_entry_t idedisk_proc[] = {
-	{ "cache",		S_IFREG|S_IRUGO,	proc_idedisk_read_cache,		NULL },
-	{ "geometry",		S_IFREG|S_IRUGO,	proc_ide_read_geometry,			NULL },
-	{ "smart_values",	S_IFREG|S_IRUSR,	proc_idedisk_read_smart_values,		NULL },
-	{ "smart_thresholds",	S_IFREG|S_IRUSR,	proc_idedisk_read_smart_thresholds,	NULL },
-	{ NULL, 0, NULL, NULL }
+	{
+		.name		= "cache",
+		.mode		= S_IFREG|S_IRUGO,
+		.read_proc	= proc_idedisk_read_cache,
+	 },
+	{
+		.name		= "geometry",
+		.mode		= S_IFREG|S_IRUGO,
+		.read_proc	= proc_ide_read_geometry,
+	},
+	{
+		.name		= "smart_values",
+		.mode		= S_IFREG|S_IRUSR,
+		.read_proc	= proc_idedisk_read_smart_values,
+	},
+	{
+		.name		= "smart_thresholds",
+		.mode		= S_IFREG|S_IRUSR,
+		.read_proc	= proc_idedisk_read_smart_thresholds,
+	},
+	{ .mode =  0 }
 };
 
 #else
-- 
Man once surrendering his reason, has no remaining guard against absurdities
the most monstrous, and like a ship without rudder, is the sport of every wind.

-Thomas Jefferson to James Smith, 1822

             reply	other threads:[~2004-12-21 20:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-21 20:24 Art Haas [this message]
2004-12-21 21:02 ` [PATCH] Small initializer patch for ide-disk.c Jeff Garzik
2004-12-21 21:29   ` John W. Linville
2004-12-21 21:30   ` Art Haas
2004-12-21 21:30   ` Andrew Morton
2004-12-21 21:51     ` Jeff Garzik
2004-12-21 21:57       ` Randy.Dunlap
2004-12-21 22:01         ` Jeff Garzik
2004-12-21 22:04           ` Randy.Dunlap
2004-12-21 22:21             ` Jeff Garzik
2004-12-21 23:06       ` Bartlomiej Zolnierkiewicz
2004-12-21 21:51     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041221202407.GD2725@artsapartment.org \
    --to=ahaas@airmail.net \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=akpm@osdl.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.