From: "John W. Linville" <linville@tuxdriver.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Art Haas <ahaas@airmail.net>, Andrew Morton <akpm@osdl.org>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] Small initializer patch for ide-disk.c
Date: Tue, 21 Dec 2004 16:29:13 -0500 [thread overview]
Message-ID: <20041221212911.GA16383@tuxdriver.com> (raw)
In-Reply-To: <41C88F73.2090606@pobox.com>
On Tue, Dec 21, 2004 at 04:02:43PM -0500, Jeff Garzik wrote:
> Art Haas wrote:
> >This patch adds C99 initializers to the file. It can clearly wait until
> The unpatched version is far more readable and maintainable.
I dunno...other than the whitespace issue before the first "}",
I like the patch.
I think the new-style struct initializers have the advantage of
associating names with parameters, rather than relying on declaration
order to match a structure definition living elsewhere.
YMMV, of course...
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2004-12-21 21:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 20:24 [PATCH] Small initializer patch for ide-disk.c Art Haas
2004-12-21 21:02 ` Jeff Garzik
2004-12-21 21:29 ` John W. Linville [this message]
2004-12-21 21:30 ` Art Haas
2004-12-21 21:30 ` Andrew Morton
2004-12-21 21:51 ` Jeff Garzik
2004-12-21 21:57 ` Randy.Dunlap
2004-12-21 22:01 ` Jeff Garzik
2004-12-21 22:04 ` Randy.Dunlap
2004-12-21 22:21 ` Jeff Garzik
2004-12-21 23:06 ` Bartlomiej Zolnierkiewicz
2004-12-21 21:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041221212911.GA16383@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=ahaas@airmail.net \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.