Re: 2.6.x BUGs at boot time (APIC related)

[William Lee Irwin III <wli@holomorphy.com>]

On Wednesday 22 December 2004 17:31, Denis Vlasenko wrote:
>>         if (!apic_id_registered())
>>                 BUG();   <=========================

On Thu, Dec 23, 2004 at 11:02:09AM +0000, Denis Vlasenko wrote:
> Tested with noapic nolapic boot params. Still happens.
> Call chain is init() -> APIC_init_uniprocessor() ->
> ->  setup_local_APIC(). I am a bit suspicious why
> APIC_init_uniprocessor() does not bail out
> if enable_local_apic<0 (i.e. if I boot with "nolapic"):
> int __init APIC_init_uniprocessor (void)
> {
>         if (enable_local_apic < 0)
>                 clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
> 		<===== missing "return -1"?
> 
>         if (!smp_found_config && !cpu_has_apic)
>                 return -1;
> ...

Sounds pretty serious. What happens if you add the missing return -1?

-- wli