From: William Lee Irwin III <wli@holomorphy.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: vda@port.imtp.ilyichevsk.odessa.ua, linux-kernel@vger.kernel.org,
mingo@redhat.com
Subject: Re: 2.6.x BUGs at boot time (APIC related)
Date: Thu, 23 Dec 2004 08:22:02 -0800 [thread overview]
Message-ID: <20041223162202.GB771@holomorphy.com> (raw)
In-Reply-To: <200412231611.iBNGBdLY022571@harpo.it.uu.se>
At some point in the past, I wrote:
>>> Sounds pretty serious. What happens if you add the missing return -1?
On Thu, 23 Dec 2004 14:57:25 +0000, Denis Vlasenko wrote:
>> Just tested that. It booted ok. Patch is in attachment.
On Thu, Dec 23, 2004 at 05:11:39PM +0100, Mikael Pettersson wrote:
> The early return just hides the real bug, whatever it is.
> I'm suspecting some bogosity with boot_cpu_physical_apicid,
> or possibly smp_found_config. Please remove the early return
> and try the patch below instead.
Dropping the early return means nolapic is not honored in this
codepath. I realize it doesn't have much impact on the bug that
happens while nolapic is not passed. Thanks for fixing that.
Also, it should probably not have to clear X86_FEATURE_APIC from
boot_cpu_data.x86_capability, because lapic_disable() already did
so. Tracking down where that is being set (if it indeed is) when
enable_local_apic < 0 may be useful.
-- wli
next prev parent reply other threads:[~2004-12-23 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 16:11 2.6.x BUGs at boot time (APIC related) Mikael Pettersson
2004-12-23 16:22 ` William Lee Irwin III [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-23 16:59 Chuck Ebbert
2004-12-22 17:31 Denis Vlasenko
2004-12-23 11:02 ` Denis Vlasenko
2004-12-23 9:12 ` William Lee Irwin III
2004-12-23 14:57 ` Denis Vlasenko
2004-12-23 9:33 ` Arnaud Patard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041223162202.GB771@holomorphy.com \
--to=wli@holomorphy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=mingo@redhat.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.