Re: [PATCH] fix gcc warning on 64 bit compile of gdth

[Al Viro <viro@parcelfarce.linux.theplanet.co.uk>]

On Tue, Jan 04, 2005 at 10:32:41AM +0100, Arjan van de Ven wrote:
> On Tue, 2005-01-04 at 10:29 +0100, Leubner, Achim wrote:
> > You are right, in gdth_fill_raw_command() the driver is doing two
> > different dma mappings, one for the data buffer stored in
> > SCp.dma_handle, and the second for the sense buffer stored in SCp.buffer
> > and host_scribble. So reuse of dma_handle does not work here.
> 
> Is there a way the driver can get rid of looking at the sense buffer at
> all and let the midlayer do this ?

AFAICS, hardware wants dma_address of that puppy passed to it.  Which might
be a solution of this problem, if that address is not clobbered and can
be read back from where we'd stored it.  But that's a question for hardware
folks - does the value of cmdp->u.{raw,raw64}.sense_data survive until we
get to unmapping stuff in gdth_sync_event()?

In any case, we really should check for failure of pci_map_...() and be
more careful with checking if two areas need to be unmapped...