From: Christoph Hellwig <hch@infradead.org>
To: "Leubner, Achim" <Achim_Leubner@adaptec.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fix gcc warning on 64 bit compile of gdth
Date: Wed, 5 Jan 2005 11:19:00 +0000 [thread overview]
Message-ID: <20050105111900.GA30954@infradead.org> (raw)
In-Reply-To: <B51CDBDEB98C094BB6E1985861F53AF302DE45@nkse2k01.adaptec.com>
On Tue, Jan 04, 2005 at 10:29:15AM +0100, Leubner, Achim wrote:
> You are right, in gdth_fill_raw_command() the driver is doing two
> different dma mappings, one for the data buffer stored in
> SCp.dma_handle, and the second for the sense buffer stored in SCp.buffer
> and host_scribble. So reuse of dma_handle does not work here.
> And, you are right, this is ugly and brittle, but there is no remaining
> space in the SCp scratch area to save the second dma mapping.
> The other patches look fine for me, thanks. But what's the reason to
> remove the support of 2.2.x and 2.4.x without the full dma API?
Too much noise in the driver for totally obsolete kernels.
next prev parent reply other threads:[~2005-01-05 11:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 9:29 [PATCH] fix gcc warning on 64 bit compile of gdth Leubner, Achim
2005-01-04 9:32 ` Arjan van de Ven
2005-01-04 10:29 ` Al Viro
2005-01-05 11:19 ` Christoph Hellwig
2005-01-04 14:55 ` James Bottomley
2005-01-05 11:19 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-04 12:08 Leubner, Achim
2005-01-04 10:57 Leubner, Achim
2005-01-04 11:53 ` Al Viro
2005-01-03 21:45 James Bottomley
2005-01-03 22:43 ` Al Viro
2005-01-03 22:49 ` James Bottomley
2005-01-03 22:54 ` Al Viro
2005-01-03 23:53 ` James Bottomley
2005-01-04 4:52 ` Al Viro
2005-01-04 8:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050105111900.GA30954@infradead.org \
--to=hch@infradead.org \
--cc=Achim_Leubner@adaptec.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.