* [KJ] [PATCH 2/28] net/act200l-sir: replace schedule_timeout() with
@ 2005-01-06 23:29 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2005-01-06 23:29 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
Hi,
Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. There aren't any waitqueue events in the area, so I believe
an absolute sleep should be ok.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.10-v/drivers/net/irda/act200l-sir.c 2004-12-24 13:34:30.000000000 -0800
+++ 2.6.10/drivers/net/irda/act200l-sir.c 2005-01-04 14:57:49.000000000 -0800
@@ -177,8 +177,7 @@ static int act200l_change_speed(struct s
/* Write control bytes */
sirdev_raw_write(dev, control, 3);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(msecs_to_jiffies(5));
+ msleep(5);
/* Go back to normal mode */
sirdev_set_dtr_rts(dev, TRUE, TRUE);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-06 23:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-06 23:29 [KJ] [PATCH 2/28] net/act200l-sir: replace schedule_timeout() with Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.