All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: cramerj@intel.com, john.ronciak@intel.com, ganesh.venkatesan@intel.com
Cc: linux-net@vger.kernel.org, kernel-janitors@lists.osdl.org,
	netdev@oss.sgi.com
Subject: [KJ] [PATCH 6/28] net/e1000_osdep: replace schedule_timeout() with
Date: Fri, 07 Jan 2005 00:19:31 +0000	[thread overview]
Message-ID: <20050107001931.GH3055@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi,

Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- 2.6.10-v/drivers/net/e1000/e1000_osdep.h	2004-12-24 13:34:26.000000000 -0800
+++ 2.6.10/drivers/net/e1000/e1000_osdep.h	2005-01-04 14:57:49.000000000 -0800
@@ -46,8 +46,7 @@
 				/* Don't mdelay in interrupt context! */ \
 	                	BUG(); \
 			} else { \
-				set_current_state(TASK_UNINTERRUPTIBLE); \
-				schedule_timeout((x * HZ)/1000 + 2); \
+				msleep(x);
 			} } while(0)
 /* Some workarounds require millisecond delays and are run during interrupt
  * context.  Most notably, when establishing link, the phy may need tweaking

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: cramerj@intel.com, john.ronciak@intel.com, ganesh.venkatesan@intel.com
Cc: linux-net@vger.kernel.org, kernel-janitors@lists.osdl.org,
	netdev@oss.sgi.com
Subject: [KJ] [PATCH 6/28] net/e1000_osdep: replace schedule_timeout() with msleep()
Date: Thu, 6 Jan 2005 16:19:31 -0800	[thread overview]
Message-ID: <20050107001931.GH3055@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi,

Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- 2.6.10-v/drivers/net/e1000/e1000_osdep.h	2004-12-24 13:34:26.000000000 -0800
+++ 2.6.10/drivers/net/e1000/e1000_osdep.h	2005-01-04 14:57:49.000000000 -0800
@@ -46,8 +46,7 @@
 				/* Don't mdelay in interrupt context! */ \
 	                	BUG(); \
 			} else { \
-				set_current_state(TASK_UNINTERRUPTIBLE); \
-				schedule_timeout((x * HZ)/1000 + 2); \
+				msleep(x);
 			} } while(0)
 /* Some workarounds require millisecond delays and are run during interrupt
  * context.  Most notably, when establishing link, the phy may need tweaking

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2005-01-07  0:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-07  0:19 Nishanth Aravamudan [this message]
2005-01-07  0:19 ` [KJ] [PATCH 6/28] net/e1000_osdep: replace schedule_timeout() with msleep() Nishanth Aravamudan
2005-01-07 21:37 ` [KJ] Re: [PATCH 6/28] net/e1000_osdep: replace schedule_timeout() Nishanth Aravamudan
2005-01-07 21:37   ` [KJ] Re: [PATCH 6/28] net/e1000_osdep: replace schedule_timeout() with msleep() Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050107001931.GH3055@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=cramerj@intel.com \
    --cc=ganesh.venkatesan@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.