All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Chris Wright <chrisw@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: node_online_map patch kills x86_64
Date: 12 Jan 2005 03:00:23 +0100
Date: Wed, 12 Jan 2005 03:00:23 +0100	[thread overview]
Message-ID: <20050112020023.GB74675@muc.de> (raw)
In-Reply-To: <20050111175313.E24171@build.pdx.osdl.net>

> SRAT: PXM 0 -> APIC 0 -> Node 1
> SRAT: PXM 1 -> APIC 1 -> Node 2
> SRAT: Node 1 PXM 0 0-9ffff
> SRAT: Node 1 PXM 0 0-3fffffff
> SRAT: Node 2 PXM 1 40000000-7fffffff
> Bootmem setup node 1 0000000000000000-000000003fffffff
> Bootmem setup node 2 0000000040000000-000000007ff5ffff
> No mptable found.
> PANIC: early exception rip ffffffff8078b2e3 error 0 cr2 17c497a67

Can you please test if this patch fixes the problem? 

Thanks, 
-Andi


Fix SRAT NUMA parsing

Fix fallout from the recent nodemask_t changes. The node ids assigned 
in the SRAT parser were off by one.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux/arch/x86_64/mm/srat.c
===================================================================
--- linux.orig/arch/x86_64/mm/srat.c	2005-01-09 18:19:17.%N +0100
+++ linux/arch/x86_64/mm/srat.c	2005-01-12 02:43:54.%N +0100
@@ -29,8 +29,8 @@
 	if (pxm2node[pxm] == 0xff) {
 		if (num_online_nodes() >= MAX_NUMNODES)
 			return -1;
-		pxm2node[pxm] = num_online_nodes();
-		node_set_online(num_online_nodes());
+		pxm2node[pxm] = num_online_nodes() - 1;
+		node_set_online(pxm2node[pxm]);
 	}
 	return pxm2node[pxm];
 }

  reply	other threads:[~2005-01-12  2:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-11 23:16 node_online_map patch kills x86_64 Chris Wright
2005-01-11 23:42 ` Andi Kleen
2005-01-12  0:30   ` Chris Wright
2005-01-12  1:38     ` Andi Kleen
2005-01-12  1:53       ` Chris Wright
2005-01-12  2:00         ` Andi Kleen [this message]
2005-01-12  2:10           ` Chris Wright
2005-01-12  0:07 ` William Lee Irwin III
2005-01-12  0:35   ` Chris Wright
2005-01-12 18:42     ` Matthew Dobson
2005-01-12 19:20       ` Chris Wright
  -- strict thread matches above, loose matches on Subject: below --
2005-01-12  2:03 Petr Vandrovec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050112020023.GB74675@muc.de \
    --to=ak@muc.de \
    --cc=chrisw@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.