* [KJ] [PATCH 15/21] net/skethtool: remove duplicate delay
@ 2005-01-17 23:44 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2005-01-17 23:44 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
Hi,
Please consider applying.
Description: Remove an unnecessary second (and identical) delay.
schedule_timeout() does not need to be called, as msleep_interruptible() already
delayed the task.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc1-kj-v/drivers/net/sk98lin/skethtool.c 2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/drivers/net/sk98lin/skethtool.c 2005-01-16 23:52:18.000000000 -0800
@@ -437,9 +437,6 @@ static int locateDevice(struct net_devic
pAC->LedsOn = 0;
mod_timer(&pAC->BlinkTimer, jiffies);
msleep_interruptible(data * 1000);
-
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(data * HZ);
del_timer_sync(&pAC->BlinkTimer);
toggleLeds(pNet, 0);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-17 23:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-17 23:44 [KJ] [PATCH 15/21] net/skethtool: remove duplicate delay Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.