[KJ] [PATCH 21/21] usb/cypress_m8: replace schedule_timeout() with

[KJ] [PATCH 21/21] usb/cypress_m8: replace schedule_timeout() with

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

Hi,

Please consider applying. 

Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. The current code is not incorrect. Using msleep(), though,
encourages specifying time delays in human time-units and consistency across the
kernel.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.11-rc1-kj-v/drivers/usb/serial/cypress_m8.c	2005-01-15 16:55:42.000000000 -0800
+++ 2.6.11-rc1-kj/drivers/usb/serial/cypress_m8.c	2005-01-17 00:17:27.000000000 -0800
@@ -49,9 +49,10 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/spinlock.h>
-#include <asm/uaccess.h>
 #include <linux/usb.h>
 #include <linux/serial.h>
+#include <linux/delay.h>
+#include <asm/uaccess.h>
 
 #ifdef CONFIG_USB_SERIAL_DEBUG
 	static int debug = 1;
@@ -916,8 +917,7 @@ static void cypress_set_termios (struct 
 	cypress_serial_control(port, baud_mask, data_bits, stop_bits, parity_enable,
 			       parity_type, 0, CYPRESS_SET_CONFIG);
 
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout(50*HZ/1000); /* give some time between change and read (50ms) */ 
+	msleep(50);			/* give some time between change and read (50ms) */
 
 	/* we perform a CYPRESS_GET_CONFIG so that the current settings are filled into the private structure
          * this should confirm that all is working if it returns what we just set */

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 21/21] usb/cypress_m8: replace schedule_timeout()

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On Mon, Jan 17, 2005 at 04:27:03PM -0800, Nishanth Aravamudan wrote:
> Hi,
> 
> Please consider applying. 
> 
> Description: Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. The current code is not incorrect. Using msleep(), though,
> encourages specifying time delays in human time-units and consistency across the
> kernel.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Applied, thanks.

greg k-h


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors