From: Nishanth Aravamudan <nacc@us.ibm.com>
To: neilb@cse.unsw.edu.au
Cc: kernel-janitors@lists.osdl.org, nfs@lists.sourceforge.net
Subject: [KJ] [PATCH 7/40] fs/nfs4callback: replace schedule_timeout() with
Date: Thu, 20 Jan 2005 19:03:52 +0000 [thread overview]
Message-ID: <20050120190352.GH5393@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Hi,
Please consider applying.
Description: Use ssleep() instead of schedule_timeout() to guarantee the task
delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc1-kj-v/fs/nfsd/nfs4callback.c 2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/fs/nfsd/nfs4callback.c 2005-01-18 11:03:27.000000000 -0800
@@ -38,6 +38,7 @@
#include <linux/list.h>
#include <linux/inet.h>
#include <linux/errno.h>
+#include <linux/delay.h>
#include <linux/sunrpc/xdr.h>
#include <linux/sunrpc/svc.h>
#include <linux/sunrpc/clnt.h>
@@ -531,8 +532,7 @@ out:
retry:
atomic_inc(&dp->dl_recall_cnt);
/* sleep 2 seconds before retrying recall */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(2*HZ);
+ ssleep(2);
status = nfsd4_cb_recall(dp);
dprintk("NFSD: nfs4_cb_recall_done: retry status: %d dp %p dl_flock %p\n",status,dp, dp->dl_flock);
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: neilb@cse.unsw.edu.au
Cc: kernel-janitors@lists.osdl.org, nfs@lists.sourceforge.net
Subject: [KJ] [PATCH 7/40] fs/nfs4callback: replace schedule_timeout() with ssleep()
Date: Thu, 20 Jan 2005 11:03:52 -0800 [thread overview]
Message-ID: <20050120190352.GH5393@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Hi,
Please consider applying.
Description: Use ssleep() instead of schedule_timeout() to guarantee the task
delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc1-kj-v/fs/nfsd/nfs4callback.c 2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/fs/nfsd/nfs4callback.c 2005-01-18 11:03:27.000000000 -0800
@@ -38,6 +38,7 @@
#include <linux/list.h>
#include <linux/inet.h>
#include <linux/errno.h>
+#include <linux/delay.h>
#include <linux/sunrpc/xdr.h>
#include <linux/sunrpc/svc.h>
#include <linux/sunrpc/clnt.h>
@@ -531,8 +532,7 @@ out:
retry:
atomic_inc(&dp->dl_recall_cnt);
/* sleep 2 seconds before retrying recall */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(2*HZ);
+ ssleep(2);
status = nfsd4_cb_recall(dp);
dprintk("NFSD: nfs4_cb_recall_done: retry status: %d dp %p dl_flock %p\n",status,dp, dp->dl_flock);
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-01-20 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 19:03 Nishanth Aravamudan [this message]
2005-01-20 19:03 ` [KJ] [PATCH 7/40] fs/nfs4callback: replace schedule_timeout() with ssleep() Nishanth Aravamudan
2005-03-01 21:31 ` [KJ] Re: [NFS] [PATCH 7/40] fs/nfs4callback: replace J. Bruce Fields
2005-03-01 21:31 ` [KJ] Re: [NFS] [PATCH 7/40] fs/nfs4callback: replace schedule_timeout() with ssleep() J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050120190352.GH5393@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.