* [KJ] [PATCH 11/40] fs/xfs_buf: replace schedule_timeout() with
@ 2005-01-20 19:12 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2005-01-20 19:12 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
Hi,
Please consider applying.
Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. The current code uses TASK_INTERRUPTIBLE, but does not check
for signals, so I believe the change to msleep() is appropriate.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc1-kj-v/fs/xfs/linux-2.6/xfs_buf.c 2005-01-15 16:55:41.000000000 -0800
+++ 2.6.11-rc1-kj/fs/xfs/linux-2.6/xfs_buf.c 2005-01-18 11:09:34.000000000 -0800
@@ -54,6 +54,7 @@
#include <linux/suspend.h>
#include <linux/percpu.h>
#include <linux/blkdev.h>
+#include <linux/delay.h>
#include "xfs_linux.h"
@@ -1689,8 +1690,7 @@ pagebuf_daemon(
if (current->flags & PF_FREEZE)
refrigerator(PF_FREEZE);
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout((xfs_buf_timer_centisecs * HZ) / 100);
+ msleep(xfs_buf_timer_centisecs * 10);
age = (xfs_buf_age_centisecs * HZ) / 100;
spin_lock(&pbd_delwrite_lock);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-20 19:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-20 19:12 [KJ] [PATCH 11/40] fs/xfs_buf: replace schedule_timeout() with Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.