All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] [PATCH 27/39] sound/gus_pcm: insert set_current_state() before
@ 2005-01-21 19:36 Nishanth Aravamudan
  2005-01-24 15:01 ` [PATCH 27/39] sound/gus_pcm: insert set_current_state() before schedule_timeout() Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2005-01-21 19:36 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

Hi,

Please consider applying.

Description: Insert set_current_state() before schedule_timeout(). Without the
insertion, schedule_timeout() returns immediately.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.11-rc1-kj-v/sound/isa/gus/gus_pcm.c	2005-01-15 16:55:45.000000000 -0800
+++ 2.6.11-rc1-kj/sound/isa/gus/gus_pcm.c	2005-01-18 13:27:24.000000000 -0800
@@ -333,6 +333,7 @@ static int snd_gf1_pcm_poke_block(snd_gu
 			}
 		}
 		if (count > 0 && !in_interrupt()) {
+			set_current_state(TASK_INTERRUPTIBLE);
 			schedule_timeout(1);
 			if (signal_pending(current))
 				return -EAGAIN;

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 27/39] sound/gus_pcm: insert set_current_state() before schedule_timeout()
  2005-01-21 19:36 [KJ] [PATCH 27/39] sound/gus_pcm: insert set_current_state() before Nishanth Aravamudan
@ 2005-01-24 15:01 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2005-01-24 15:01 UTC (permalink / raw)
  To: Nishanth Aravamudan; +Cc: perex, alsa-devel, kernel-janitors

At Fri, 21 Jan 2005 11:36:36 -0800,
Nishanth Aravamudan wrote:
> 
> Hi,
> 
> Please consider applying.
> 
> Description: Insert set_current_state() before schedule_timeout(). Without the
> insertion, schedule_timeout() returns immediately.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Thanks, applied to ALSA tree together with other patches.

Only the patches for vx_core.c and emu8000.c are slightly modified due
to the reason I posted.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-01-24 15:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-21 19:36 [KJ] [PATCH 27/39] sound/gus_pcm: insert set_current_state() before Nishanth Aravamudan
2005-01-24 15:01 ` [PATCH 27/39] sound/gus_pcm: insert set_current_state() before schedule_timeout() Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.