* [KJ] [PATCH 31/39] sound/wavefront_synth: insert
@ 2005-01-21 19:49 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2005-01-21 19:49 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
Hi,
Please consider applying.
Description: Insert set_current_state() before schedule_timeout(). Without the
insertion, schedule_timeout() returns immediately, resulting in an effective
busy-wait.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc1-kj-v/sound/isa/wavefront/wavefront_synth.c 2005-01-15 16:55:45.000000000 -0800
+++ 2.6.11-rc1-kj/sound/isa/wavefront/wavefront_synth.c 2005-01-18 13:38:54.000000000 -0800
@@ -1751,6 +1751,7 @@ wavefront_should_cause_interrupt (snd_wa
outb (val,port);
spin_unlock_irq(&dev->irq_lock);
while (1) {
+ set_current_state(TASK_INTERRUPTIBLE);
if ((timeout = schedule_timeout(timeout)) == 0)
return;
if (dev->irq_ok)
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-21 19:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-21 19:49 [KJ] [PATCH 31/39] sound/wavefront_synth: insert Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.