All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [linux-usb-devel] [PATCH 36/39] usb/kaweth: use
Date: Fri, 21 Jan 2005 22:05:57 +0000	[thread overview]
Message-ID: <20050121220557.GV3340@us.ibm.com> (raw)
In-Reply-To: <200501212302.32887.oliver@neukum.org>

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

On Fri, Jan 21, 2005 at 11:02:32PM +0100, Oliver Neukum wrote:
> Am Freitag, 21. Januar 2005 22:36 schrieb Nishanth Aravamudan:
> > Hi,
> > 
> > Please consider applying.
> > 
> > Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> > now unused variables. I changed the code to only add to the wait-queue if
> > necessary, but I'm not sure if this is correct.
> 
> The macro seems essentially identical. If it compiles, what problems are
> you afraid of?

Oh I agree the code is identical, but if you look at the patch, I don't add to
the queue before the if(status) check (which, if true, will remove from the
wait-queue). I just wasn't sure if that part of the chane would be ok
(intuitively it seemed so to me, but I'm not a wait-queue expert).

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      reply	other threads:[~2005-01-21 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-21 22:02 [KJ] Re: [linux-usb-devel] [PATCH 36/39] usb/kaweth: use Oliver Neukum
2005-01-21 22:05 ` Nishanth Aravamudan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050121220557.GV3340@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.