* [KJ] Re: [linux-usb-devel] [PATCH 36/39] usb/kaweth: use
@ 2005-01-21 22:02 Oliver Neukum
2005-01-21 22:05 ` Nishanth Aravamudan
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2005-01-21 22:02 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
Am Freitag, 21. Januar 2005 22:36 schrieb Nishanth Aravamudan:
> Hi,
>
> Please consider applying.
>
> Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> now unused variables. I changed the code to only add to the wait-queue if
> necessary, but I'm not sure if this is correct.
The macro seems essentially identical. If it compiles, what problems are
you afraid of?
Regards
Oliver
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* [KJ] Re: [linux-usb-devel] [PATCH 36/39] usb/kaweth: use
2005-01-21 22:02 [KJ] Re: [linux-usb-devel] [PATCH 36/39] usb/kaweth: use Oliver Neukum
@ 2005-01-21 22:05 ` Nishanth Aravamudan
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Aravamudan @ 2005-01-21 22:05 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Fri, Jan 21, 2005 at 11:02:32PM +0100, Oliver Neukum wrote:
> Am Freitag, 21. Januar 2005 22:36 schrieb Nishanth Aravamudan:
> > Hi,
> >
> > Please consider applying.
> >
> > Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> > now unused variables. I changed the code to only add to the wait-queue if
> > necessary, but I'm not sure if this is correct.
>
> The macro seems essentially identical. If it compiles, what problems are
> you afraid of?
Oh I agree the code is identical, but if you look at the patch, I don't add to
the queue before the if(status) check (which, if true, will remove from the
wait-queue). I just wasn't sure if that part of the chane would be ok
(intuitively it seemed so to me, but I'm not a wait-queue expert).
Thanks,
Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-21 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-21 22:02 [KJ] Re: [linux-usb-devel] [PATCH 36/39] usb/kaweth: use Oliver Neukum
2005-01-21 22:05 ` Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.