From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Vasily Averin <vvs@sw.ru>
Cc: Marcelo Tosatti <marcello.tosatti@cyclades.com>,
Andrey Melnikov <temnota+kernel@kmv.ru>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Prevent NMI oopser
Date: Tue, 25 Jan 2005 07:35:02 -0200 [thread overview]
Message-ID: <20050125093502.GA19585@logos.cnet> (raw)
In-Reply-To: <41F5F98C.7020004@sw.ru>
On Tue, Jan 25, 2005 at 10:47:24AM +0300, Vasily Averin wrote:
> Marcello, Andrey
>
> I believe this patch is wrong.
> First, it prevent nothing: NMI watchdog is a signal that you wait too
> long with disabled interrupts. Your controller was not answered too
> long, obviously it is a hardware issue.
> Second, you could not call schedule() with io_request_lock spinlock taken.
>
> You should unlock io_request_lock before msleep, like in latest versions
> of megaraid2 drivers.
>
> Please fix it.
OK, I've reverted it for now - waiting for megaraid2 update from LSI crew.
next prev parent reply other threads:[~2005-01-25 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-25 7:47 [PATCH] Prevent NMI oopser Vasily Averin
2005-01-25 9:35 ` Marcelo Tosatti [this message]
[not found] <41F5FC96.2010103@sw.ru>
2005-01-31 23:17 ` Marcelo Tosatti
2005-02-02 18:42 ` Vasily Averin
2005-02-02 18:53 ` Andrey J. Melnikoff (TEMHOTA)
2005-02-02 19:06 ` Matt Domsch
2005-02-02 19:32 ` Vasily Averin
2005-02-02 20:19 ` Matt Domsch
2005-02-02 21:08 ` Andrey J. Melnikoff (TEMHOTA)
2005-02-02 19:39 ` Vasily Averin
2005-02-02 19:50 ` Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125093502.GA19585@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcello.tosatti@cyclades.com \
--cc=temnota+kernel@kmv.ru \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.