All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasily Averin <vvs@sw.ru>
To: Marcelo Tosatti <marcello.tosatti@cyclades.com>,
	Andrey Melnikov <temnota+kernel@kmv.ru>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Prevent NMI oopser
Date: Tue, 25 Jan 2005 10:47:24 +0300	[thread overview]
Message-ID: <41F5F98C.7020004@sw.ru> (raw)

Marcello, Andrey

I believe this patch is wrong.
First, it prevent nothing: NMI watchdog is a signal that you wait too 
long with disabled interrupts. Your controller was not answered too 
long, obviously it is a hardware issue.
Second, you could not call schedule() with io_request_lock spinlock taken.

You should unlock io_request_lock before msleep, like in latest versions 
of megaraid2 drivers.

Please fix it.

Thank you,
      Vasily Averin, SWSoft Linux Kernel Team

# ChangeSet
#   2005/01/19 14:16:32-02:00 temnota@kmv.ru
#   [PATCH] Prevent NMI oopser from triggering when megaraid2 waits
#   for abort/reset cmd completion
#
#   > We should backport msleep() in 2.4.29-pre1.
#
#   Ok, msleep() backported, but driver isn't fixed. This patch
#   acceptable?
#
#   Prevent NMI oopser kill kernel thread when megaraid2 driver waiting
#   abort or reset command completion.
#
#   Signed-off-by: Andrey Melnikov <temnota+kernel@kmv.ru>



             reply	other threads:[~2005-01-25  7:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-25  7:47 Vasily Averin [this message]
2005-01-25  9:35 ` [PATCH] Prevent NMI oopser Marcelo Tosatti
     [not found] <41F5FC96.2010103@sw.ru>
2005-01-31 23:17 ` Marcelo Tosatti
2005-02-02 18:42   ` Vasily Averin
2005-02-02 18:53     ` Andrey J. Melnikoff (TEMHOTA)
2005-02-02 19:06     ` Matt Domsch
2005-02-02 19:32       ` Vasily Averin
2005-02-02 20:19         ` Matt Domsch
2005-02-02 21:08           ` Andrey J. Melnikoff (TEMHOTA)
2005-02-02 19:39       ` Vasily Averin
2005-02-02 19:50       ` Vasily Averin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41F5F98C.7020004@sw.ru \
    --to=vvs@sw.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcello.tosatti@cyclades.com \
    --cc=temnota+kernel@kmv.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.