[KJ] [PATCH] 8/34: block/swim3: replace interruptible_sleep_on()

[KJ] [PATCH] 8/34: block/swim3: replace interruptible_sleep_on()

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

Hi,

Please consider applying.

Description: Use wait_event_interruptible() instead of the deprecated
interruptible_sleep_on(). The change is pretty straight-forward, as the current
sleep is conditional.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- 2.6.11-rc2-kj-v/drivers/block/swim3.c	2005-01-25 14:38:30.000000000 -0800
+++ 2.6.11-rc2-kj/drivers/block/swim3.c	2005-01-24 14:02:49.000000000 -0800
@@ -28,6 +28,7 @@
 #include <linux/devfs_fs_kernel.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
+#include <linux/wait.h>
 #include <asm/io.h>
 #include <asm/dbdma.h>
 #include <asm/prom.h>
@@ -792,13 +793,11 @@ static int grab_drive(struct floppy_stat
 	cli();
 	if (fs->state != idle) {
 		++fs->wanted;
-		while (fs->state != available) {
-			if (interruptible && signal_pending(current)) {
-				--fs->wanted;
-				restore_flags(flags);
-				return -EINTR;
-			}
-			interruptible_sleep_on(&fs->wait);
+		wait_event_interruptible(fs->wait, (fs->state == available));
+		if (interruptible && signal_pending(current)) {
+			--fs->wanted;
+			restore_flags(flags);
+			return -EINTR;
 		}
 		--fs->wanted;
 	}

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors