From: "David S. Miller" <davem@davemloft.net>
To: Patrick McHardy <kaber@trash.net>
Cc: hadi@cyberus.ca, rusty@rustcorp.com.au,
netfilter-devel@lists.netfilter.org
Subject: Re: skb_ip_make_writable and skbs not owned by a socket
Date: Wed, 26 Jan 2005 21:50:39 -0800 [thread overview]
Message-ID: <20050126215039.65ebd158.davem@davemloft.net> (raw)
In-Reply-To: <41F869C2.5030800@trash.net>
On Thu, 27 Jan 2005 05:10:42 +0100
Patrick McHardy <kaber@trash.net> wrote:
> Dave, could you please have another look at this ? I think the patch is
> correct, and even necessary to make the ipt action work with targets
> that mangle the data area. Jamal asked me to put back the pskb_expand_head
> call in the ipt action, so iptables won't see cloned skbs and copy them
> (actions must not replace the skb), but the protocol-dependant cases
> in skb_ip_make_writable can cause copying anyway. I think you missed
> my reply to your last mail, please see below.
It's in my backlog, don't worry. I'll try to get to it tomorrow.
Is it the end of the world if I defer it to 2.6.12?
next prev parent reply other threads:[~2005-01-27 5:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-02 21:19 skb_ip_make_writable and skbs not owned by a socket Patrick McHardy
2005-01-02 23:57 ` Thomas Graf
2005-01-03 1:36 ` Patrick McHardy
2005-01-03 1:53 ` Patrick McHardy
2005-01-03 14:55 ` jamal
2005-01-14 5:31 ` David S. Miller
2005-01-14 5:59 ` Patrick McHardy
2005-01-14 6:08 ` David S. Miller
2005-01-17 21:50 ` David S. Miller
2005-01-17 23:13 ` Patrick McHardy
2005-01-27 4:10 ` Patrick McHardy
2005-01-27 5:50 ` David S. Miller [this message]
2005-01-27 14:41 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050126215039.65ebd158.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.