From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: rusty@rustcorp.com.au, netfilter-devel@lists.netfilter.org
Subject: Re: skb_ip_make_writable and skbs not owned by a socket
Date: Tue, 18 Jan 2005 00:13:35 +0100 [thread overview]
Message-ID: <41EC469F.6010605@trash.net> (raw)
In-Reply-To: <20050117135029.04e6580f.davem@davemloft.net>
David S. Miller wrote:
>This code is doing something different. Even if we unclone and
>unshare the SKB, the packet header portion can still be non-linear.
>
>It will be possible for devices to create this situation on receive.
>That's why we have all the pskb_may_pull() checks in all the major
>ipv4 protocol input paths.
>
The patch already calls pskb_may_pull for unshared/uncloned skbs, so it
linearizes them up to the requested size. It just replaces skb_copy by
pskb_may_pull when the data area of unshared/uncloned skbs needs to be
mangled.
Regards
Patrick
next prev parent reply other threads:[~2005-01-17 23:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-02 21:19 skb_ip_make_writable and skbs not owned by a socket Patrick McHardy
2005-01-02 23:57 ` Thomas Graf
2005-01-03 1:36 ` Patrick McHardy
2005-01-03 1:53 ` Patrick McHardy
2005-01-03 14:55 ` jamal
2005-01-14 5:31 ` David S. Miller
2005-01-14 5:59 ` Patrick McHardy
2005-01-14 6:08 ` David S. Miller
2005-01-17 21:50 ` David S. Miller
2005-01-17 23:13 ` Patrick McHardy [this message]
2005-01-27 4:10 ` Patrick McHardy
2005-01-27 5:50 ` David S. Miller
2005-01-27 14:41 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41EC469F.6010605@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.