* [PATCH] use misc dynamic minor for sonypi driver
@ 2005-01-27 13:46 Olaf Hering
2005-01-27 14:02 ` Stelian Pop
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2005-01-27 13:46 UTC (permalink / raw)
To: linux-kernel, Stelian Pop; +Cc: Andrew Morton
Whats the reason for using -1 as minor number?
No idea if that works well, it probably does.
Maybe add a comment if -1 is supposed to work.
--- ../linux-2.6.11-rc2/drivers/char/sonypi.c 2005-01-22 02:48:34.000000000 +0100
+++ ./drivers/char/sonypi.c 2005-01-27 14:40:47.873882682 +0100
@@ -649,7 +649,7 @@
};
struct miscdevice sonypi_misc_device = {
- .minor = -1,
+ .minor = MISC_DYNAMIC_MINOR,
.name = "sonypi",
.fops = &sonypi_misc_fops,
};
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] use misc dynamic minor for sonypi driver
2005-01-27 13:46 [PATCH] use misc dynamic minor for sonypi driver Olaf Hering
@ 2005-01-27 14:02 ` Stelian Pop
0 siblings, 0 replies; 2+ messages in thread
From: Stelian Pop @ 2005-01-27 14:02 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-kernel, Andrew Morton
On Thu, Jan 27, 2005 at 02:46:40PM +0100, Olaf Hering wrote:
>
> Whats the reason for using -1 as minor number?
> No idea if that works well, it probably does.
> Maybe add a comment if -1 is supposed to work.
>
>
> --- ../linux-2.6.11-rc2/drivers/char/sonypi.c 2005-01-22 02:48:34.000000000 +0100
> +++ ./drivers/char/sonypi.c 2005-01-27 14:40:47.873882682 +0100
> @@ -649,7 +649,7 @@
> };
>
> struct miscdevice sonypi_misc_device = {
> - .minor = -1,
> + .minor = MISC_DYNAMIC_MINOR,
> .name = "sonypi",
> .fops = &sonypi_misc_fops,
> };
It works because sonypi_misc_device.minor get overridden later:
662 sonypi_misc_device.minor = (minor == -1) ?
663 MISC_DYNAMIC_MINOR : minor;
This test could be simplified too in addition to your patch.
Stelian.
--
Stelian Pop <stelian@popies.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-27 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-27 13:46 [PATCH] use misc dynamic minor for sonypi driver Olaf Hering
2005-01-27 14:02 ` Stelian Pop
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.