From: Martin Zwickel <martin.zwickel@technotrend.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
hugang@soulinfo.com, Pavel Machek <pavel@suse.cz>,
Nigel Cunningham <ncunningham@linuxmail.org>
Subject: Re: [RFC][PATCH] swsusp: do not use higher order memory allocations on suspend
Date: Fri, 28 Jan 2005 15:07:56 +0100 [thread overview]
Message-ID: <20050128150756.1d6976cb@phoebee> (raw)
In-Reply-To: <200501281454.23167.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
> @@ -373,15 +377,22 @@
>
> static int write_pagedir(void)
> {
> - unsigned long addr = (unsigned long)pagedir_nosave;
> int error = 0;
> - int n = SUSPEND_PD_PAGES(nr_copy_pages);
> - int i;
> + unsigned n = 0;
> + struct pbe * pbe;
> +
> + printk( "Writing pagedir ...");
>
> +
> + pr_debug("\b\b\bdone (%u pages)\n", n);
Just cosmetic:
Why do you use pr_debug here instead of printk like you did above?
--
MyExcuse:
the printer thinks its a router.
Martin Zwickel <martin.zwickel@technotrend.de>
Research & Development
TechnoTrend AG <http://www.technotrend.de>
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-01-28 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 13:54 [RFC][PATCH] swsusp: do not use higher order memory allocations on suspend Rafael J. Wysocki
2005-01-28 14:07 ` Martin Zwickel [this message]
2005-01-28 17:52 ` Rafael J. Wysocki
2005-01-28 17:24 ` Pavel Machek
2005-01-28 18:31 ` Rafael J. Wysocki
[not found] ` <200501300052.55545.rjw@sisk.pl>
[not found] ` <20050131130631.GF6279@elf.ucw.cz>
[not found] ` <200501311510.12979.rjw@sisk.pl>
2005-01-31 18:20 ` Pavel Machek
2005-01-31 18:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050128150756.1d6976cb@phoebee \
--to=martin.zwickel@technotrend.de \
--cc=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.