* [PATCH 5/9] Use netdev_priv in baycom_par driver
@ 2005-01-30 21:32 Ralf Baechle DL5RB
0 siblings, 0 replies; only message in thread
From: Ralf Baechle DL5RB @ 2005-01-30 21:32 UTC (permalink / raw)
To: linux-hams; +Cc: Jeff Garzik
Eleminate the last remaining instance of a direct reference to the priv
member of struct net_device. This was debug code only, so use BUG_ON()
instead of printk.
baycom_par.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
Index: bk-afu/drivers/net/hamradio/baycom_par.c
===================================================================
--- bk-afu.orig/drivers/net/hamradio/baycom_par.c
+++ bk-afu/drivers/net/hamradio/baycom_par.c
@@ -85,6 +85,7 @@
#include <linux/parport.h>
#include <linux/bitops.h>
+#include <asm/bug.h>
#include <asm/system.h>
#include <asm/uaccess.h>
@@ -415,12 +416,11 @@
struct baycom_state *bc;
struct baycom_ioctl bi;
- if (!dev || !dev->priv ||
- ((struct baycom_state *)dev->priv)->hdrv.magic != HDLCDRV_MAGIC) {
- printk(KERN_ERR "bc_ioctl: invalid device struct\n");
+ if (!dev)
return -EINVAL;
- }
+
bc = netdev_priv(dev);
+ BUG_ON(bc->hdrv.magic != HDLCDRV_MAGIC);
if (cmd != SIOCDEVPRIVATE)
return -ENOIOCTLCMD;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-30 21:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-30 21:32 [PATCH 5/9] Use netdev_priv in baycom_par driver Ralf Baechle DL5RB
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.