[KJ] [PATCH 13/20] sound/gus_pcm: remove

[KJ] [PATCH 13/20] sound/gus_pcm: remove

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

Hello,

Please consider applying.

Description: Replace deprecated interruptible_sleep_on_timeout() with
wait_event_timeout(). Code is not identical, as the current sleeping system is 1
jiffy at a time checking atomic_read()'s return every iteration. Patch is
compile-tested.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.11-rc2-kj-v/sound/isa/gus/gus_pcm.c	2005-01-26 11:19:06.000000000 -0800
+++ 2.6.11-rc2-kj/sound/isa/gus/gus_pcm.c	2005-02-02 11:34:20.000000000 -0800
@@ -697,16 +697,10 @@ static int snd_gf1_pcm_playback_close(sn
 	snd_gus_card_t *gus = snd_pcm_substream_chip(substream);
 	snd_pcm_runtime_t *runtime = substream->runtime;
 	gus_pcm_private_t *pcmp = runtime->private_data;
-	unsigned long jiffies_old;
+	
+	if (!wait_event_timeout(pcmp->sleep, (atomic_read(&pcmp->dma_count) <= 0), 2*HZ))
+		snd_printk("gf1 pcm - serious DMA problem\n");
 
-	jiffies_old = jiffies;
-	while (atomic_read(&pcmp->dma_count) > 0) {
-		interruptible_sleep_on_timeout(&pcmp->sleep, 1);
-		if ((signed long)(jiffies - jiffies_old) > 2*HZ) {
-			snd_printk("gf1 pcm - serious DMA problem\n");
-			break;
-		}
-	}
 	snd_gf1_dma_done(gus);	
 	return 0;
 }

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [Alsa-devel] [PATCH 13/20] sound/gus_pcm: remove

[Takashi Iwai]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

At Wed, 2 Feb 2005 11:50:13 -0800,
Nishanth Aravamudan wrote:
> 
> Hello,
> 
> Please consider applying.
> 
> Description: Replace deprecated interruptible_sleep_on_timeout() with
> wait_event_timeout(). Code is not identical, as the current sleeping system is 1
> jiffy at a time checking atomic_read()'s return every iteration. Patch is
> compile-tested.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Thanks, I applied this one.

The other fixes for sound/seq/* stuff are not applied.  Instead, I
modified the code to use wait_event*() properly.
Now all sleep_on*() are gone from ALSA tree.


Takashi

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [PATCH 13/20] sound/gus_pcm: remove interruptible_sleep_on_timeout() usage

[Nishanth Aravamudan]

On Fri, Feb 04, 2005 at 04:33:04PM +0100, Takashi Iwai wrote:
> At Wed, 2 Feb 2005 11:50:13 -0800,
> Nishanth Aravamudan wrote:
> > 
> > Hello,
> > 
> > Please consider applying.
> > 
> > Description: Replace deprecated interruptible_sleep_on_timeout() with
> > wait_event_timeout(). Code is not identical, as the current sleeping system is 1
> > jiffy at a time checking atomic_read()'s return every iteration. Patch is
> > compile-tested.
> > 
> > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> Thanks, I applied this one.
> 
> The other fixes for sound/seq/* stuff are not applied.  Instead, I
> modified the code to use wait_event*() properly.
> Now all sleep_on*() are gone from ALSA tree.

Great! Thanks for all your help, Takashi!

-Nish


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl

[KJ] Re: [Alsa-devel] [PATCH 13/20] sound/gus_pcm: remove

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

On Fri, Feb 04, 2005 at 04:33:04PM +0100, Takashi Iwai wrote:
> At Wed, 2 Feb 2005 11:50:13 -0800,
> Nishanth Aravamudan wrote:
> > 
> > Hello,
> > 
> > Please consider applying.
> > 
> > Description: Replace deprecated interruptible_sleep_on_timeout() with
> > wait_event_timeout(). Code is not identical, as the current sleeping system is 1
> > jiffy at a time checking atomic_read()'s return every iteration. Patch is
> > compile-tested.
> > 
> > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> Thanks, I applied this one.
> 
> The other fixes for sound/seq/* stuff are not applied.  Instead, I
> modified the code to use wait_event*() properly.
> Now all sleep_on*() are gone from ALSA tree.

Great! Thanks for all your help, Takashi!

-Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [PATCH 13/20] sound/gus_pcm: remove interruptible_sleep_on_timeout() usage

[Takashi Iwai]

At Wed, 2 Feb 2005 11:50:13 -0800,
Nishanth Aravamudan wrote:
> 
> Hello,
> 
> Please consider applying.
> 
> Description: Replace deprecated interruptible_sleep_on_timeout() with
> wait_event_timeout(). Code is not identical, as the current sleeping system is 1
> jiffy at a time checking atomic_read()'s return every iteration. Patch is
> compile-tested.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Thanks, I applied this one.

The other fixes for sound/seq/* stuff are not applied.  Instead, I
modified the code to use wait_event*() properly.
Now all sleep_on*() are gone from ALSA tree.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl