All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] Arm host float endian fix
@ 2005-02-06  1:03 Paul Brook
  2005-02-06 12:31 ` Lennert Buytenhek
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Brook @ 2005-02-06  1:03 UTC (permalink / raw)
  To: qemu-devel

The newer arm VFP floating point units store double values with natural 
word-ordering, unlike the old FPA unit which always used big-endian.

Patch below updates host conditionals to reflect this.

Paul

Index: cpu-all.h
===================================================================
RCS file: /cvsroot/qemu/qemu/cpu-all.h,v
retrieving revision 1.39
diff -u -p -r1.39 cpu-all.h
--- cpu-all.h 28 Jan 2005 22:37:22 -0000 1.39
+++ cpu-all.h 6 Feb 2005 00:57:27 -0000
@@ -114,10 +114,11 @@ static inline void tswap64s(uint64_t *s)
 #define tswapls(s) tswap64s((uint64_t *)(s))
 #endif
 
-/* NOTE: arm is horrible as double 32 bit words are stored in big endian ! */
+/* NOTE: arm FPA is horrible as double 32 bit words are stored in big endian!
+ */
 typedef union {
     double d;
-#if !defined(WORDS_BIGENDIAN) && !defined(__arm__)
+#if !defined(WORDS_BIGENDIAN) && !defined(__arm__) && !defined (__VFP_FP__)
     struct {
         uint32_t lower;
         uint32_t upper;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] Arm host float endian fix
  2005-02-06  1:03 [Qemu-devel] Arm host float endian fix Paul Brook
@ 2005-02-06 12:31 ` Lennert Buytenhek
  0 siblings, 0 replies; 2+ messages in thread
From: Lennert Buytenhek @ 2005-02-06 12:31 UTC (permalink / raw)
  To: qemu-devel

On Sun, Feb 06, 2005 at 01:03:29AM +0000, Paul Brook wrote:

> The newer arm VFP floating point units store double values with natural 
> word-ordering, unlike the old FPA unit which always used big-endian.

While we're on the subject, something similar to the patch in this
email is also still needed for proper floating point emulation if the
host and (ARM) target are not both little-endian.

	http://lists.gnu.org/archive/html/qemu-devel/2004-12/msg00339.html


--L

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-02-06 12:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-06  1:03 [Qemu-devel] Arm host float endian fix Paul Brook
2005-02-06 12:31 ` Lennert Buytenhek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.