From: khali@linux-fr.org (Jean Delvare)
To: Alexey Dobriyan <adobriyan@mail.ru>, "Mark A. Greer" <mgreer@mvista.com>
Cc: Greg KH <greg@kroah.com>,
LM Sensors <sensors@stimpy.netroedge.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH][I2C] Marvell mv64xxx i2c driver
Date: Thu, 19 May 2005 06:25:36 +0000 [thread overview]
Message-ID: <20050206153600.2d8fb127.khali@linux-fr.org> (raw)
In-Reply-To: <3s6eEus2.1107510325.6106480.khali@localhost>
Hi all,
Quoting myself:
> I am as surprised as you are to see this here. I2C_ALGO_AU1550 should
> really be made a different value. There is also a problem with
> I2C_ALGO_PCA and I2C_ALGO_SIBYTE having the same value, which was
> already reported to Greg some days ago if memory serves. I think I
> will send a patch against 2.6.10-rc3 to Linus this evening, which
> fixes the broken algo IDs. That way Mark can keep the algorithm ID he
> is using right now, and each algorithm will get its own, unique ID, as
> should be.
I've changed my mind since. There isn't anything critical here and
pushing random patches to Linus right before he releases 2.6.11 wouldn't
have been particularly subtle. So I instead sent a patch to Greg, as can
be seen here:
http://archives.andrew.net.au/lm-sensors/msg29405.html
So Mark, providing Greg accepts this patch, you can assume that
I2C_ALGO_MV64XXX is already properly defined in Greg's tree (where your
own patch will end up) so you don't need to add it yourself. You will
still have to define I2C_HW_MV64XXX though.
Thanks,
--
Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Alexey Dobriyan <adobriyan@mail.ru>, "Mark A. Greer" <mgreer@mvista.com>
Cc: Greg KH <greg@kroah.com>,
LM Sensors <sensors@stimpy.netroedge.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][I2C] Marvell mv64xxx i2c driver
Date: Sun, 6 Feb 2005 15:36:00 +0100 [thread overview]
Message-ID: <20050206153600.2d8fb127.khali@linux-fr.org> (raw)
In-Reply-To: <3s6eEus2.1107510325.6106480.khali@localhost>
Hi all,
Quoting myself:
> I am as surprised as you are to see this here. I2C_ALGO_AU1550 should
> really be made a different value. There is also a problem with
> I2C_ALGO_PCA and I2C_ALGO_SIBYTE having the same value, which was
> already reported to Greg some days ago if memory serves. I think I
> will send a patch against 2.6.10-rc3 to Linus this evening, which
> fixes the broken algo IDs. That way Mark can keep the algorithm ID he
> is using right now, and each algorithm will get its own, unique ID, as
> should be.
I've changed my mind since. There isn't anything critical here and
pushing random patches to Linus right before he releases 2.6.11 wouldn't
have been particularly subtle. So I instead sent a patch to Greg, as can
be seen here:
http://archives.andrew.net.au/lm-sensors/msg29405.html
So Mark, providing Greg accepts this patch, you can assume that
I2C_ALGO_MV64XXX is already properly defined in Greg's tree (where your
own patch will end up) so you don't need to add it yourself. You will
still have to define I2C_HW_MV64XXX though.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-26 1:26 [PATCH][I2C] Marvell mv64xxx i2c driver Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-01-26 19:56 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-01-26 20:33 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-01-26 21:56 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-01-26 22:42 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-01-26 23:59 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-01-31 18:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-01-31 18:41 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-02-01 0:46 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-02-01 17:54 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-05-19 6:25 ` Alexey Dobriyan
2005-02-02 1:27 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-02-02 17:26 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-05-19 6:25 ` Alexey Dobriyan
2005-02-03 19:12 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-02-04 0:38 ` Alexey Dobriyan
2005-05-19 6:25 ` Alexey Dobriyan
2005-02-04 0:04 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-02-04 9:45 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2005-02-06 14:36 ` Jean Delvare [this message]
2005-05-19 6:25 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2005-01-26 1:29 Mark A. Greer
2005-02-08 23:27 Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-02-09 0:01 ` Bartlomiej Zolnierkiewicz
2005-05-19 6:25 ` Bartlomiej Zolnierkiewicz
2005-02-09 0:32 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-02-09 1:24 ` Bartlomiej Zolnierkiewicz
2005-05-19 6:25 ` Bartlomiej Zolnierkiewicz
2005-02-09 21:33 ` Mark A. Greer
2005-05-19 6:25 ` Mark A. Greer
2005-02-17 22:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050206153600.2d8fb127.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=adobriyan@mail.ru \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@mvista.com \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.