All of lore.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] drivers/isdn/tpam/: possible cleanups
@ 2005-02-09  3:00 Adrian Bunk
  0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2005-02-09  3:00 UTC (permalink / raw)
  To: kkeil, kai.germaschewski; +Cc: isdn4linux, linux-kernel

This patch makes the following possible cleanups:
- tpam_hdlc.c: make the needlessly global variable stuffs static
- tpam_nco.c: remove the unused global function build_ADestroyNCOReq

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/isdn/tpam/tpam.h      |    1 -
 drivers/isdn/tpam/tpam_hdlc.c |    2 +-
 drivers/isdn/tpam/tpam_nco.c  |   27 ---------------------------
 3 files changed, 1 insertion(+), 29 deletions(-)

--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_hdlc.c.old	2005-02-09 03:39:54.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_hdlc.c	2005-02-09 03:40:02.000000000 +0100
@@ -548,7 +548,7 @@
 
 
 static WORD * stuffs[] = { stuff0, stuff1, stuff2, stuff3, stuff4, stuff5 };
-WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 };
+static WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 };
 
 
 /*- AuverTech Telecom -------------------------------------------------------+
--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam.h.old	2005-02-09 03:40:16.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam.h	2005-02-09 03:40:21.000000000 +0100
@@ -181,7 +181,6 @@
 
 /* Function prototypes from tpam_nco.c */
 extern struct sk_buff *build_ACreateNCOReq(const u8 *);
-extern struct sk_buff *build_ADestroyNCOReq(u32);
 extern struct sk_buff *build_CConnectReq(u32, const u8 *, u8);
 extern struct sk_buff *build_CConnectRsp(u32);
 extern struct sk_buff *build_CDisconnectReq(u32);
--- linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_nco.c.old	2005-02-09 03:40:29.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/isdn/tpam/tpam_nco.c	2005-02-09 03:42:52.000000000 +0100
@@ -131,33 +131,6 @@
 }
 
 /*
- * Build a ADestroyNCOReq message.
- *
- * 	ncoid: the NCO id.
- *
- * Return: the sk_buff filled with the NCO packet, or NULL if error.
- */
-struct sk_buff *build_ADestroyNCOReq(u32 ncoid) {
-	struct sk_buff *skb;
-	u8 *tlv;
-
-	pr_debug("TurboPAM(build_ADestroyNCOReq): ncoid=%lu\n",
-		(unsigned long)ncoid);
-
-	/* build the NCO packet */
-	if (!(skb = build_NCOpacket(ID_ADestroyNCOReq, 6, 0, 0, 0)))
-		return NULL;
-	
-	/* add the parameters */
-	tlv = (u8 *)skb_put(skb, 6);
-	*tlv = PAR_NCOID;
-	*(tlv+1) = 4;
-	*((u32 *)(tlv+2)) = ncoid;
-
-	return skb;
-}
-
-/*
  * Build a CConnectReq message.
  *
  * 	ncoid: the NCO id.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-02-09  3:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-09  3:00 [2.6 patch] drivers/isdn/tpam/: possible cleanups Adrian Bunk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.